Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent label/annotations names should follow K8s name conventions (aka. kebab-case) #12103

Closed
cardil opened this issue Oct 7, 2021 · 1 comment · Fixed by #12329
Closed
Assignees
Labels
area/API API objects and controllers area/autoscale area/networking kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@cardil
Copy link

cardil commented Oct 7, 2021

Some labels/annotations used in Serving use kebab case like no-gc (see: https://knative.dev/docs/serving/revision-gc/#revision-garbage-collection), others use dot separator like ingress.class (see: https://knative.dev/docs/developer/serving/services/ingress-class/#using-the-ingress-class-annotation), and others use camel case like minScale (see: https://knative.dev/docs/serving/autoscaling/scale-bounds/#lower-bound).

Kubernetes has a naming convention for labels and annotations. It uses kebab case - see: https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels

Also, there's an issue #7300 which makes a similar change to config maps, so it adds to the inconsistency.

/area API
/area autoscale
/area networking

Expected Behavior

Knative should follow Kubernetes guidelines closely, and all annotations and labels should be renamed to be written in kebab case.

Actual Behavior

Some labels and annotations are using a different notation than others.

@cardil cardil added the kind/bug Categorizes issue or PR as related to a bug. label Oct 7, 2021
@cardil cardil changed the title Inconsistent label names should follow K8s name conventions (aka. kebab-case) Inconsistent label/annotations names should follow K8s name conventions (aka. kebab-case) Oct 7, 2021
@dprotaso
Copy link
Member

/assign @dprotaso

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/API API objects and controllers area/autoscale area/networking kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants