Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use apps.deployment instead of extensions.deployment #344

Closed
vaikas opened this issue Mar 27, 2019 · 0 comments
Closed

use apps.deployment instead of extensions.deployment #344

vaikas opened this issue Mar 27, 2019 · 0 comments
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@vaikas
Copy link
Contributor

vaikas commented Mar 27, 2019

Expected Behavior

use the latest version of deployment instead of extensions v1beta1

Actual Behavior

uses v1beta1

Steps to Reproduce the Problem

  1. In webhook/webhook.go we use v1beta1 extensions
  2. don't. use apps instead which is v1.

Additional Info
@knative-prow-robot knative-prow-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 27, 2019
@vaikas vaikas mentioned this issue Mar 27, 2019
Merged
chengjingtao pushed a commit to katanomi/knative-pkg that referenced this issue Oct 22, 2024
@yuzp1996
Skip transform for creating when adding approval operator if skipCrea…
9a2f023 
…teCheck (knative#344)

Transform for creating eventing will add wrong operator in some
case for example automate approval for stageRun.

So we skip the tranfrom for create operation base on skipCreateCheck.

Signed-off-by: yuzhipeng <[email protected]>

Signed-off-by: yuzhipeng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vaikas @knative-prow-robot