-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't propagate kebab-case annotations to internal networking types #12313
don't propagate kebab-case annotations to internal networking types #12313
Conversation
/assign @nak3 |
Codecov Report
@@ Coverage Diff @@
## main #12313 +/- ##
==========================================
+ Coverage 87.52% 87.57% +0.04%
==========================================
Files 195 195
Lines 9594 9631 +37
==========================================
+ Hits 8397 8434 +37
Misses 917 917
Partials 280 280
Continue to review full report at Codecov.
|
152e102
to
4e378fb
Compare
4e378fb
to
e1a438a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, psschwei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
note: a prior knative.dev/networking dependency bump added support for this already [here](-
https://github.com/knative/serving/pull/12315/files#diff-3cbf862804033eee2a74359afd3314ab56212340da183a31a3d62f3cc2a186d0R113-R143)
This PR just ensures kebab case annotations aren't propagated to the KIngress & KCert since not all implementation recognize them
Part of #12103