Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't propagate kebab-case annotations to internal networking types #12313

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Nov 18, 2021

note: a prior knative.dev/networking dependency bump added support for this already [here](-
https://github.com/knative/serving/pull/12315/files#diff-3cbf862804033eee2a74359afd3314ab56212340da183a31a3d62f3cc2a186d0R113-R143)

This PR just ensures kebab case annotations aren't propagated to the KIngress & KCert since not all implementation recognize them

  • don't set alternate annotations on internal networking types

Part of #12103

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 18, 2021
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/API API objects and controllers area/networking approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 18, 2021
@dprotaso
Copy link
Member Author

/assign @nak3

@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #12313 (e1a438a) into main (a816f59) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12313      +/-   ##
==========================================
+ Coverage   87.52%   87.57%   +0.04%     
==========================================
  Files         195      195              
  Lines        9594     9631      +37     
==========================================
+ Hits         8397     8434      +37     
  Misses        917      917              
  Partials      280      280              
Impacted Files Coverage Δ
pkg/reconciler/route/resources/filters.go 100.00% <ø> (ø)
pkg/reconciler/domainmapping/resources/ingress.go 100.00% <100.00%> (ø)
pkg/reconciler/route/resources/certificate.go 100.00% <100.00%> (ø)
pkg/reconciler/route/resources/ingress.go 93.14% <100.00%> (+0.07%) ⬆️
pkg/reconciler/configuration/configuration.go 84.61% <0.00%> (-1.54%) ⬇️
pkg/reconciler/revision/background.go 91.81% <0.00%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a816f59...e1a438a. Read the comment docs.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 19, 2021
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 19, 2021
@dprotaso dprotaso changed the title support kebab-case for some networking annotations don't propagate kebab-case annotations to internal networking types Nov 20, 2021
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 89ac2aa into knative:main Nov 23, 2021
@dprotaso dprotaso deleted the kebab-case-annotations branch November 23, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/networking cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants