Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run kind e2e in release branches #11127

Merged
merged 2 commits into from
Apr 8, 2021

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Apr 7, 2021

No description provided.

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 7, 2021
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 7, 2021
@dprotaso
Copy link
Member Author

dprotaso commented Apr 7, 2021

/cherry-pick release-0.22
/cherry-pick release-0.21

@knative-prow-robot
Copy link
Contributor

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-0.22 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.22
/cherry-pick release-0.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #11127 (ce0f670) into main (1f297ad) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head ce0f670 differs from pull request most recent head 8b956ea. Consider uploading reports for the commit 8b956ea to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11127      +/-   ##
==========================================
+ Coverage   87.68%   87.72%   +0.03%     
==========================================
  Files         190      190              
  Lines        9162     9162              
==========================================
+ Hits         8034     8037       +3     
+ Misses        873      872       -1     
+ Partials      255      253       -2     
Impacted Files Coverage Δ
pkg/autoscaler/scaling/multiscaler.go 87.61% <0.00%> (-1.77%) ⬇️
pkg/autoscaler/statforwarder/leases.go 76.97% <0.00%> (-1.44%) ⬇️
pkg/reconciler/configuration/configuration.go 88.28% <0.00%> (+1.56%) ⬆️
pkg/autoscaler/statforwarder/processor.go 94.44% <0.00%> (+5.55%) ⬆️
pkg/autoscaler/statforwarder/forwarder.go 96.29% <0.00%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f297ad...8b956ea. Read the comment docs.

@dprotaso
Copy link
Member Author

dprotaso commented Apr 7, 2021

/retest

@@ -2,7 +2,7 @@ name: KinD e2e tests

on:
pull_request:
branches: [ 'main', 'master' ]
branches: [ 'main', 'master', 'release-*' ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's drop master while we're on it.

Copy link
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2021
@knative-prow-robot knative-prow-robot merged commit 47f56c6 into knative:main Apr 8, 2021
@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #11139

In response to this:

/cherry-pick release-0.22
/cherry-pick release-0.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants