Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move all fuzz stuff to _test files #9726

Merged
merged 2 commits into from
Oct 7, 2020

Conversation

vagababov
Copy link
Contributor

Fixes #9725

/assign @dprotaso mattmoor

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 7, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 7, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vagababov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2020
@knative-prow-robot knative-prow-robot added the area/API API objects and controllers label Oct 7, 2020
@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

Merging #9726 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9726      +/-   ##
==========================================
- Coverage   87.99%   87.93%   -0.06%     
==========================================
  Files         177      176       -1     
  Lines        8449     8424      -25     
==========================================
- Hits         7435     7408      -27     
- Misses        771      772       +1     
- Partials      243      244       +1     
Impacted Files Coverage Δ
pkg/reconciler/configuration/configuration.go 87.50% <0.00%> (-1.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f5e1cc...0866fc5. Read the comment docs.

@dprotaso
Copy link
Member

dprotaso commented Oct 7, 2020

Can we actually move the funcs to a fuzzer subpackage

@dprotaso
Copy link
Member

dprotaso commented Oct 7, 2020

That’s what’s we’re gonna do in Knative.dev/pkg and I’ve seen it across the k8s codebase

@dprotaso
Copy link
Member

dprotaso commented Oct 7, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2020
@knative-prow-robot knative-prow-robot merged commit fad9d55 into knative:master Oct 7, 2020
@vagababov vagababov deleted the 20201007-rm-fuz branch October 8, 2020 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Our binaries are shipping test packages
4 participants