Unconditionally set the base image annotation. #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we only set this annotation when our base image was a tag, but this means when folks actually follow the best practice of use digest base images they get strictly worse resulting images! It sounds like maybe the original motivation for this condition was that it was supposed to contain the mutable reference (tag), but I don't see anything detailing such a restriction (just an example), so there should be nothing precluding this from the spec.
|
This also supports: #744 |
Codecov Report
@@ Coverage Diff @@
## main #745 +/- ##
==========================================
- Coverage 51.38% 51.35% -0.03%
==========================================
Files 44 44
Lines 3295 3293 -2
==========================================
- Hits 1693 1691 -2
Misses 1390 1390
Partials 212 212
Continue to review full report at Codecov.
|
imjasonh
requested changes
Jul 3, 2022
pkg/build/gobuild.go
Outdated
| if _, ok := baseRef.(name.Tag); ok { | ||
| anns[specsv1.AnnotationBaseImageName] = baseRef.Name() | ||
| } | ||
| anns[specsv1.AnnotationBaseImageName] = baseRef.Name() |
There was a problem hiding this comment.
The nittiest of nits: can you just put this in the map initialization expression above, with the other one?
imjasonh
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we only set this annotation when our base image was a tag, but this means when folks actually follow the best practice of use digest base images they get strictly worse resulting images!
It sounds like maybe the original motivation for this condition was that it was supposed to contain the mutable reference (tag), but I don't see anything detailing such a restriction (just an example), so there should be nothing
precluding this from the spec.