Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unconditionally set the base image annotation. #745

Merged
merged 2 commits into from
Jul 5, 2022
Merged

Unconditionally set the base image annotation. #745

merged 2 commits into from
Jul 5, 2022

Commits on Jul 3, 2022

  1. Unconditionally set the base image annotation. 

    Previously we only set this annotation when our base image was a tag, but this means when folks actually follow the best practice of use digest base images they get strictly worse resulting images!

It sounds like maybe the original motivation for this condition was that it was supposed to contain the mutable reference (tag), but I don't see anything detailing such a restriction (just an example), so there should be nothing
precluding this from the spec.
    @mattmoor
    mattmoor committed Jul 3, 2022
    Configuration menu
    Copy the full SHA
    195c844 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2022

  1. Fold assignment into map initialization.

    @mattmoor
    mattmoor committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    8e7dfd5 View commit details
    Browse the repository at this point in the history