Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Downloads improvements - custom data exports UI #3012

Merged
merged 79 commits into from
Mar 19, 2021

Conversation

magicznyleszek
Copy link
Member

@magicznyleszek magicznyleszek commented Feb 16, 2021

Description

Improves the UI for Project Downloads by adding a few more export options and a way of saving the settings for later use.

Additional details

Includes code from 2967-custom-data-exports (#2975) and osm-geojson-export-and-endpoint and #3011 branches.

Related issues

Closes #2963
Closes #3062
Part of #2881

jsapp/js/actions/exports.es6 Outdated Show resolved Hide resolved
jsapp/js/components/projectDownloads/exportsConstants.es6 Outdated Show resolved Hide resolved
jsapp/js/components/projectDownloads/exportsConstants.es6 Outdated Show resolved Hide resolved
jsapp/js/constants.es6 Outdated Show resolved Hide resolved
jsapp/js/dataInterface.es6 Show resolved Hide resolved
kpi/models/import_export_task.py Outdated Show resolved Hide resolved
@magicznyleszek
Copy link
Member Author

@jnm fixed all review comments, and also introduced all the changes requested in #3062

Comment on lines +473 to +477
{t('Export')}
 
<em>{t('Select Many')}</em>
&nbsp;
{t('questions as…')}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@magicznyleszek, this is a good example of a translation that will be difficult without context, especially for RTL languages. Maybe leaving the emphasis tags in the translatable string would be better(?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants