-
-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project Downloads improvements - custom data exports UI #3012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s with base branch
# Conflicts: # jsapp/scss/components/_kobo.simple-table.scss
jnm
requested changes
Mar 10, 2021
Merged
…tringified-bools Remove dependency on stringified bools
…kpi into 2963-custom-data-exports-fe
…kpi into 2963-custom-data-exports-fe
jnm
approved these changes
Mar 19, 2021
Comment on lines
+473
to
+477
{t('Export')} | ||
| ||
<em>{t('Select Many')}</em> | ||
| ||
{t('questions as…')} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@magicznyleszek, this is a good example of a translation that will be difficult without context, especially for RTL languages. Maybe leaving the emphasis tags in the translatable string would be better(?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves the UI for Project Downloads by adding a few more export options and a way of saving the settings for later use.
Additional details
Includes code from
2967-custom-data-exports
(#2975) andosm-geojson-export-and-endpoint
and #3011 branches.Related issues
Closes #2963
Closes #3062
Part of #2881