Incorporate previously reviewed changes (for 2.021.24) #3288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alphabetized-methods
…-feature-combined
…rt-settings Link export with export-settings
Automated pushing translation strings to Transifex
…bined' into 3032-library-locking-ui
Don't force form media's `dropzone` look everywhere
Add `sync_kobocat_form_media` management command
…edia` to `False`
…t_form_media` sub-commands
Update `sync_kobocat_xform` command
* Since the feature is new on all collects, specify version number * wording: "functionality only works in" -> "functionality available in"
# Conflicts: # jsapp/js/components/formLanding.es6 # jsapp/js/components/formSummary.es6 # jsapp/js/components/formViewTabs.es6 # jsapp/js/components/header.es6 # jsapp/js/components/library/ownedCollectionsStore.es6 # jsapp/js/components/reportViewItem.es6 # jsapp/js/constants.es6 # jsapp/js/utils.es6 # jsapp/scss/components/_kobo.drawer.scss # jsapp/scss/components/_kobo.form-view.scss # locale
[Feature] Adds `background-audio` as a meta question type into formbuilder
Feature: Library Locking UI
Fix outdated color names and obvious merge conflicts that I didn't notice until front-end compilation failed
Fix skip logic
jdugh
pushed a commit
to geohyd/kpi
that referenced
this pull request
Nov 21, 2022
Incorporate previously reviewed changes (for 2.021.24)
jdugh
pushed a commit
to geohyd/kpi
that referenced
this pull request
Nov 13, 2023
Incorporate previously reviewed changes (for 2.021.24)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This, plus changes already in
master, will become release 2.021.24.Fixes missing skip logic value selector issue that was introduced on the beta branch but never released.
This includes the huge #3120 PR and we should wait for it to be merged before tackling this.
Fixes #2994
background-audioas a meta question type into formbuilderCan now add a
background-audiometa question to forms via the formbuilder sidebar:Fixes #3275
sync_kobocat_xformcommandsync_kobocat_form_mediamanagement commandManagement command,
sync_kobocat_form_media, created to allow for form-media from kobocat to be synced with KPI's replacement model.dropzonelook everywhereRevert global
dropzoneCSS changes, make changes specific to form media's dropzone."Table" tab is first now and is the default tab for "Data" section. "Reports" tab will now be second.
Selectors like "Country", "Sector" and few more are searchable now.
First iteration of form media got some upgrades:
- more spacing between components
- more clear UI elements (fonts, sizes of components)
Fixes a small bug with missing styles for report styles tabs.
Users can attach media files to their form and to preview them directly from KPI. Legacy interface is not used anymore.
Files are synchronized (asynchronously) on deployment only.
Related to #2675
Reorder methods of deployment back-end classes alphabetically for better readability.
This PR modifies the
MockDeploymentBackendclass to make it behave a little bit more likeKobocatDeploymentBackendwhen deploying assets. It lets our unit tests cover more code that's used for asset deployment.Introduced new future friendly names for gray color variables. Also updated the general hue and saturation of grays (went a bit more blue).
Fixed positioning of form view close button.
Created an admin view to track users usage for number of submissions, number of forms created and number of forms deployed
part of kobotoolbox/kobocat#703
Adds locking to the translation modal. Specifically, if a question, choice, or group label is locked, it's respective label in every translation is locked in the update translation modal
Known caveats: #3213
Splitting the Table View related code into separate directory with some cleanup.
Part of #3225
Fix hiding Submission links column. Never hide checkboxes column.
Fixes #3228
Overloads GenericField class to check for KobocatContentType objects instead of ContentType.
Shadow models are reading data from KoBoCAT databases, so related objects should get content types from the same DB.
Content types can differ between databases
Removed the
_()wrapping used to identify which strings should be translated from any of the strings which do not appear to the front end users.Added a shell script to automate creating PO files and pushing them to Transifex.
Improve linter configuration to allow more compact arrow functions.
Split Reports code into multiple files to make maintaining it easier.
Add prettier configuration file for better development.
AnonymousUserlisted permissions on public assetNow included in
masterbranch by #3256; can omit from release notesMore (visually) distinct disabled state for light buttons.
Whenever collection method link is missing from endponit (e.g. due to Enketo error), show a warning information instead of broken button.
Allow creating projects from any viewable templates (previously user needed edit permissions).
Adds a hack fix that removes last asset from list view after it's been deleted
Add the non-owner self removal option introduced in #2984 to the actions available in form landing (to compliment where a user would expect the sharing options to be for an owned form):
Automated the task of pushing an updated list of translation strings
This is to keep our translations as accurate as possible and all strings will be pushed to Transifex every time a PR to the Master branch is made.
Include
export-settingsname in the exportdataobject if provided.blocked by kobotoolbox/formpack#240
Backend support for library locking features, integrating the new formpack changes.
blocked by kobotoolbox/formpack#236
Delete entire group functionality. Now whenever use clicks the delete group button, a modal will be displayed to choose wheter they want to simply ungroup or delete everything.
Needed for #3032 (will merge it there before this is reviewed)
manage_assetpermission to remove other non-owners' permissionsA fix to allow non-owners with
manage_assetpermissions to manage all permissions of a form including removing all permissions of other non-owners.Fixing a few coffeescript lines that were raisng compiler errors for linter.
A better new icon for "Expand / collapse questions" button.
Added coffee code linting configuration file. Almost all the rules added are set to "warn" level. This is going to be helpful for #3018 to clean up the code before running scripts.
All of our icons now are self designed, we stopped using FontAwesome. Some of the icons got updated. Also introduced consistent loading spinner with message.
Part of #3032
Fixed bug where if user deleted a project they would not be redirected back to the form list
Adds a dropdown menu item on the asset list page that lets a non-owner remove forms that are shared with them from their asset list.
Alternative solution to react router's
isActivefor checking wheter a route is your current route. Needed for non-components.Add comments for developers describing the
_statusfield, which comes from KoBoCATThe selected defined export settings should be cleared on any form changes. This PR fixes the last few inputs that weren't clearing it properly.
Also includes disabling "select all" (rows) when all are selected and "unselect all" (rows) when none are selected.
This is small code refactor change, nothing user oriented. I moved one of the stores to a separate file to avoid potential circular import warning.
Implemented
actionsto help serve the form media modal. Improves error handling and extensibility.Very basic UI made to replace the KC iframe in
settings/media. Still basic and needs ui design but functionality described below has been achieved:- [x] Upload single files
- [x] Upload multiple files (I only noticed this was possible a few days ago ! )
- [x] Add media URLs (pending back-end support)
- [x] View current files
- [x] View current URLs
- [x] Delete files
- [x] Remove URLs
- [x] Remove owner only access to form media page (#2647, #2657)
URL functionality pending back-end support: https://www.flowdock.com/app/kobotoolbox/kobo/threads/78V2a4RfL2rIlTdbZuuFkplFkc2
Functionality so far: