Code refactoring for project deployment #5036
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noliveleger
changed the title
…-2-remove-imports
…django-app-part-2-openrosa-backend
This was referenced Jul 30, 2024
…_update_submissions"
…t-django-app-part-2-remove-kobocat-backend
- Remove logger.XForm `has_kpi_hook` field - Remove logger.Instance `posted_to_kpi` field - Remove openrosa.rest_service django app - Remove hook signal viewset
This was referenced Jul 31, 2024
…emove-imports Code refactoring - Replace shadow models imports with their openrosa app counterparts
…penrosa-backend Code refactoring: Create new deployment backend class
…emove-kobocat-backend Code refactoring - Remove shadow models and KobocatDeploymentBackend class
…-2-remove-kobocat-rest-service
…emove-kobocat-rest-service Code refactoring: Remove RestService
noliveleger
changed the base branch from
release/2.024.33
to
release/2.024.36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for devs interest only. It should simplify the way projects are deployed and how KPI interacts with KoboCAT.
Notes
Since KoboCAT is part of KPI code base in
openrosadjango app,KobocatDeploymentBackend, shadow models are not needed anymore. The goal of this PR is to regroup many other small PRs which make a part of refactoring (i.e. to avoid a big PR to review).Replace shadow models import with openrosa model counterparts (Code refactoring - Replace shadow models imports with their openrosa app counterparts #5037)CreateOpenRosaDeploymentBackend(which calls directly Python code instead using a proxy to KoboCAT endpoints) (Code refactoring: Create new deployment backend class #5038)RemoveKobocatDeploymentBackend(Code refactoring - Remove shadow models and KobocatDeploymentBackend class #5042)Remove RestService HTTP Call from KC to KPI (Code refactoring: Remove RestService #5041)kobo_service_accountdependency #5045)MockDeploymentBackendand fix unit tests (Code refactoring: Simplify MockDeploymentBackend #5056)Related issues