Code refactoring - Replace shadow models imports with their openrosa app counterparts #5037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
noliveleger
changed the title
jnm
approved these changes
Aug 20, 2024
| @@ -429,7 +431,7 @@ def test_google_transcript_post(self, m1, m2): | |||
| 'submission': submission_id, | |||
| 'q1': {GOOGLETS: {'status': 'requested', 'languageCode': ''}} | |||
| } | |||
| with self.assertNumQueries(FuzzyInt(51, 57)): | |||
| with self.assertNumQueries(FuzzyInt(210, 215)): | |||
There was a problem hiding this comment.
We discussed that this only affects tests and is temporary, due to creating XForms on the fly:
https://github.com/kobotoolbox/kpi/pull/5037/files#diff-3c6227c824c76da07fffa9c1cae3296a272e63c4eb7a633b2795a8d62e207a02R727
jnm
requested changes
Aug 20, 2024
| @@ -38,39 +36,6 @@ | |||
| ) | |||
|
|
|||
|
|
|||
| def update_autofield_sequence(model): | |||
There was a problem hiding this comment.
This is still called by KobocatUser.sync() in this file, but it's not imported from its new location kpi/utils/database.py.
There was a problem hiding this comment.
jnm
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
Part I of #5036. Remove shadow models imports everywhere except in
KobocatDeploymentBackendRelated issues
#5036