Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expiration and time column of offers on profile #11030

Merged
merged 6 commits into from
Oct 7, 2024

Conversation

hassnian
Copy link
Contributor

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Needs Design check

Screenshot 📸

  • My fix has changed something on UI;

CleanShot 2024-09-23 at 13 27 11@2x

@hassnian hassnian requested a review from a team as a code owner September 23, 2024 08:34
@hassnian hassnian requested review from vikiival and removed request for a team September 23, 2024 08:34
Copy link

netlify bot commented Sep 23, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit d3432b0
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6703bb904c45f70008dfa1fe
😎 Deploy Preview https://deploy-preview-11030--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vikiival
Copy link
Member

Btw, speck v14 has fixed expiration :)

@Jarsen136
Copy link
Contributor

Is the text Withdraw amount proper there? Afaik, It only cancels the offer but does nothing regarding the token amount. (No funds are reserved when creating an offer) @vikiival

@vikiival
Copy link
Member

(No funds are reserved when creating an offer)

that's true

So let's call it somehow else? e.g Withdraw offer
cc @exezbcz

@exezbcz
Copy link
Member

exezbcz commented Sep 23, 2024

@vikiival so why we are doing auto offer refund after they are expired?

it is not that because of the funds are reserved?

if not funds are reserved, why don't we just hide the expired offer? Though you have to withdraw something

had a chat with @hassnian

linking

Copy link

sonarcloud bot commented Oct 7, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expiration and time column of offers on profile
4 participants