Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(beta): 48% of October 2024 Cherry 🍒 #11109

Merged
merged 35 commits into from
Oct 16, 2024
Merged

(beta): 48% of October 2024 Cherry 🍒 #11109

merged 35 commits into from
Oct 16, 2024

Conversation

vikiival
Copy link
Member

Beta Update

uDaiko and others added 24 commits October 1, 2024 16:06
@uDaiko
function to trim trailing zeroes
d6b23e4 
applied to all displayed price values
@uDaiko
edge case check for no price value
8dcc99d
@uDaiko
refactor to minimize lines
60ffab6
@uDaiko
util function to trim trailing zeroes
88dd3c1
@uDaiko
refactor card components to use new util function
fc71868
@kkukelka
[skip ci] updated code diagram
30c4f9e
@uDaiko
removed new util function
5ac0103
@uDaiko
replaced util function again (reset shenanigans)
07aec2e
@uDaiko
Merge branch 'kodadot:main' into trim_trailing_zeroes
3dc9b54
@uDaiko
changed composable function to filter falsys
3acbe34
@uDaiko
refactored to use round composable directly
47f65b1
@uDaiko
Merge branch 'trim_trailing_zeroes' of https://github.com/uDaiko/nft-…
9a9f948 
…gallery into trim_trailing_zeroes
@vikiival
Merge pull request #11079 from kodadot/action
f086fed 
[skip ci] updated code diagram
@uDaiko
moved formatting code into separate function
8a7b9b2
@uDaiko
modified format function for usd amount
d03e197 
also renamed it accordingly
@vikiival
🏷️ correct type for attribute
e4eb2e2
@vikiival
🐛 attributes should be handled normally
70114ec
@vikiival
⚡ attributes
b8da1be
@vikiival
Merge pull request #11098 from kodadot/fix/attributes
53f38bc 
fix/attributes
@Jarsen136
fix: Open in new tab does not work
173ad7b
@hassnian
ref(useAmount.ts): revert to simpler code
405b0f7
@hassnian
Merge branch 'main' into trim_trailing_zeroes
9214de3
@hassnian
fix(useMetaTransaction.ts): long message on cancelled transaction
73bc736
@roiLeo
🔧 ImageMedia object-contain
140c4b9
@vikiival vikiival added the beta label Oct 15, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 15, 2024 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit e6751b1
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/670fb8098027d20008829ec1
😎 Deploy Preview https://deploy-preview-11109--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Oct 15, 2024 •
edited
Loading

✅ Deploy Preview for koda-beta ready!

Name Link
🔨 Latest commit e6751b1
🔍 Latest deploy log https://app.netlify.com/sites/koda-beta/deploys/670fb809d54a540009f8ef9d
😎 Deploy Preview https://deploy-preview-11109--koda-beta.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vikiival vikiival changed the title (beta): October 2024 (beta): 48% of October 2024 Oct 15, 2024
@vikiival vikiival changed the title (beta): 48% of October 2024 (beta): 48% of October 2024 Cherry 🍒 Oct 15, 2024
@vikiival
Merge pull request #11104 from Jarsen136/issue-11103
f1f424f 
fix: Open in new tab does not work
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Oct 15, 2024 •
edited
Loading

Deploying koda-art-prod with  Cloudflare Pages  Cloudflare Pages

Latest commit: e6751b1
Status:⚡️  Build in progress...

View logs

@vikiival vikiival marked this pull request as ready for review October 15, 2024 14:59
@vikiival vikiival requested a review from a team as a code owner October 15, 2024 14:59
@vikiival vikiival requested review from preschian and Jarsen136 and removed request for a team October 15, 2024 14:59
@vikiival vikiival mentioned this pull request Oct 16, 2024
Merged
@vikiival vikiival merged commit f01ff70 into beta Oct 16, 2024
24 of 26 checks passed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian Awaiting requested review from preschian preschian is a code owner automatically assigned from kodadot/code-review-guild

@Jarsen136 Jarsen136 Awaiting requested review from Jarsen136 Jarsen136 is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vikiival @uDaiko @kkukelka @Jarsen136 @hassnian @roiLeo