Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add collection in lastEvent query #137

Merged
merged 3 commits into from
Sep 20, 2022

Conversation

preschian
Copy link
Member

Thank you for your contribution to the KodaDot Indexer.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've run the indexer and it hasn't failed
  • I've changed schema and performed a migration
  • I found edge cases

Screenshot

  • My contribution is a resolver so I have pic from playground

Screen Shot 2022-09-12 at 19 46 32

@preschian
Copy link
Member Author

cc @roiLeo @vikiival requesting a review
I'm unable to edit reviewers through GitHub panel
Screen Shot 2022-09-12 at 19 52 41

changed files under src/model/generated are coming from just codegen, is that expected?

@roiLeo
Copy link
Contributor

roiLeo commented Sep 12, 2022

ref kodadot/snek#64, looks good

changed files under src/model/generated are coming from just codegen, is that expected?

I have no idea about this point

@vikiival
Copy link
Member

changed files under src/model/generated are coming from just codegen, is that expected?

it should not change tbh

@preschian
Copy link
Member Author

it should not change tbh

reverted those files 👌

@vikiival vikiival merged commit 83acd0f into kodadot:main Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants