Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

add collection in lastEvent #64

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

preschian
Copy link
Member

@preschian preschian commented Sep 9, 2022

Thank you for your contribution to the KodaDot Indexer.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've run the indexer and it hasn't failed
  • I've changed schema and performed a migration
  • I found edge cases

Screenshot

  • My contribution is a resolver so I have pic from playground

Screen Shot 2022-09-09 at 21 54 14

@preschian
Copy link
Member Author

first time to adjust indexer, is this the correct way to add collection in lastEvent query?
regarding this issue kodadot/nft-gallery#3927 (comment)

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good

Have you tested it locally?

@preschian
Copy link
Member Author

Have you tested it locally?

yes, I provide the screenshot. that was from my localhost

@roiLeo
Copy link
Contributor

roiLeo commented Sep 12, 2022

yes, I provide the screenshot. that was from my localhost

is it normal that collectionName value is the same as name?

edit:
nvm fancy cats =/= fancy cat

@vikiival vikiival merged commit 94d1ad5 into kodadot:main Sep 20, 2022
@preschian preschian deleted the add-collection-name-in-last-event branch February 22, 2023 15:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants