Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(skhd): use service instead of plist #27

Closed
wants to merge 6 commits into from
Closed

fix(skhd): use service instead of plist #27

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d697a8d
use service instead of plist
mvllow Feb 9, 2023
e170f2a
fix `require_root` and `environment_variables`
mvllow Feb 9, 2023
d305f58
rename `err_log_path` to `error_log_path`
mvllow Feb 9, 2023
939f562
interpolate more strings for safety
mvllow Feb 9, 2023
24cd6e0
Update skhd.rb
mvllow Feb 14, 2023
475e44c
implement suggestions per @hunterliao29
mvllow Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 14 additions & 62 deletions skhd.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,70 +23,22 @@ def caveats; <<~EOS
EOS
end

plist_options :manual => "skhd"

if build.with? "logging"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this option necessary? It's not present in yabai. Happy to remove and do logging by default if desired.

Copy link

@jorpilo jorpilo Mar 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, I don't think this is necessary and yabai.rb just does logging by default. You will need to also remove option "with-logging", "Redirect stdout and stderr to log files" from line 8

def plist; <<~EOS
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>Label</key>
<string>#{plist_name}</string>
<key>ProgramArguments</key>
<array>
<string>#{opt_bin}/skhd</string>
</array>
<key>EnvironmentVariables</key>
<dict>
<key>PATH</key>
<string>#{HOMEBREW_PREFIX}/bin:/usr/bin:/bin:/usr/sbin:/sbin</string>
</dict>
<key>RunAtLoad</key>
<true/>
<key>KeepAlive</key>
<true/>
<key>StandardOutPath</key>
<string>#{var}/log/skhd/skhd.out.log</string>
<key>StandardErrorPath</key>
<string>#{var}/log/skhd/skhd.err.log</string>
<key>ProcessType</key>
<string>Interactive</string>
<key>Nice</key>
<integer>-20</integer>
</dict>
</plist>
EOS
end
service do
run "#{opt_bin}/skhd"
environment_variables PATH: std_service_path_env
keep_alive true
log_path "#{var}/log/skhd/skhd.out.log"
error_log_path "#{var}/log/skhd/skhd.err.log"
process_type :interactive
end
else
def plist; <<~EOS
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>Label</key>
<string>#{plist_name}</string>
<key>ProgramArguments</key>
<array>
<string>#{opt_bin}/skhd</string>
</array>
<key>EnvironmentVariables</key>
<dict>
<key>PATH</key>
<string>#{HOMEBREW_PREFIX}/bin:/usr/bin:/bin:/usr/sbin:/sbin</string>
</dict>
<key>RunAtLoad</key>
<true/>
<key>KeepAlive</key>
<true/>
<key>ProcessType</key>
<string>Interactive</string>
<key>Nice</key>
<integer>-20</integer>
</dict>
</plist>
EOS
end
service do
run "#{opt_bin}/skhd"
environment_variables PATH: std_service_path_env
keep_alive true
process_type :interactive
end
end

test do
Expand Down