fix(skhd): use service instead of plist #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvllow
force-pushed
the
replace-plist-api
branch
from
cbc7d7f
to
01f52a4
Compare
mvllow
force-pushed
the
replace-plist-api
branch
from
01f52a4
to
e170f2a
Compare
mvllow
commented
Feb 9, 2023
| @@ -23,70 +23,26 @@ def caveats; <<~EOS | |||
| EOS | |||
| end | |||
|
|
|||
| plist_options :manual => "skhd" | |||
|
|
|||
| if build.with? "logging" | |||
There was a problem hiding this comment.
Is this option necessary? It's not present in yabai. Happy to remove and do logging by default if desired.
There was a problem hiding this comment.
I agree, I don't think this is necessary and yabai.rb just does logging by default. You will need to also remove option "with-logging", "Redirect stdout and stderr to log files" from line 8
Co-authored-by: jliaoh <[email protected]>
- Update environment variables - Remove root requirement - Remove update interval
|
Replaced by #30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying #25 to skhd as well :)
Tested via:
Ref #26