Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(yabai): deprecated plist to service #31

Closed
wants to merge 2 commits into from

Conversation

jorpilo
Copy link

@jorpilo jorpilo commented Mar 4, 2023

Adding another PR to see if we can get this going.

This includes the skhd changes from #25 with all the comments addressed.

If you want to test it you can tap the master branch of my work which should include the updated formulae

@mvllow can you check if there is any further comment?

@angeljuarez77
Copy link

Hey, just learned about yabai and funnily enough saw that you posted this PR right as I got the plist issue. I tested your tap to see if it would fix yabai on my computer and it did! :)

@koekeishiya
Copy link
Owner

Is there an equivalent to

      <key>ThrottleInterval</key>
      <integer>30</integer>

and

      <key>Nice</key>
      <integer>-20</integer>

@jorpilo
Copy link
Author

jorpilo commented Mar 9, 2023

Sadly I couldn't find any equivalent to ThrottleInterval or Nice anywhere in the reference:
https://rubydoc.brew.sh/Homebrew/Service.html

Maybe we can open an issue in https://github.com/Homebrew/brew/issues asking for equivalents

@jorpilo
Copy link
Author

jorpilo commented Mar 9, 2023

I have created Homebrew/brew#14931

This is the relevant brew file that defines the services
https://github.com/Homebrew/brew/blob/58f7cb0d4e53db4df85d167b780cece0fef6762c/Library/Homebrew/service.rb

I will try to add it when I get some time

@khaneliman khaneliman mentioned this pull request Mar 19, 2023
@koekeishiya
Copy link
Owner

I've added launchd integration directly into yabai on master; koekeishiya/yabai#1619 (comment)

@koekeishiya
Copy link
Owner

removed brew services integration.

@koekeishiya koekeishiya closed this May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants