fix(skhd): deprecated plist to service with logging #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jliaoh <[email protected]>
- Update environment variables - Remove root requirement - Remove update interval
|
@mvllow can you verify if there is any further comment? |
jorpilo
changed the title
jorpilo
changed the title
|
Both this and #31 look great :) |
|
Who needs to merge this? @koekeishiya could you review and merge? |
Closed
|
Same issue as with #31, waiting for Brew to fix their API. |
|
Will probably add launchd integration directly into skhd and rework how logging works; see koekeishiya/yabai#1619 (comment) for description of how this works in yabai. |
|
Replaced brew services. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding another PR to see if we can get this going.
This includes the skhd changes from #27 without the logging parameter
If you want to test it you can tap the master branch of my work which should include the updated formulae