Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window is zoomed out from parent node when tree changes #227

Closed
malfario opened this issue Aug 30, 2019 · 2 comments
Closed

Window is zoomed out from parent node when tree changes #227

malfario opened this issue Aug 30, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@malfario
Copy link

malfario commented Aug 30, 2019

Steps to reproduce:

  1. Lay out three windows like this:
A
-- C
B
  1. Run yabai -m window --toggle zoom-parent on A. It takes over B's space.
  2. Make any change to the tree (ie. open a new window, increase/decrease A size, etc).

A is visually zoomed out, but the window's internal state is not updated:

$ yabai -m query --windows --space 1
{
        "id":9807,
        ...
        "zoom-parent":1,
        "zoom-fullscreen":0,
        "native-fullscreen":0
}

As a result, running yabai -m window --toggle zoom-parent again on A does nothing (visually) as it's really setting zoom-parent = 0, which is already set.

@koekeishiya koekeishiya added the bug Something isn't working label Aug 30, 2019
@koekeishiya koekeishiya added the addressed on master; not released Fixed upstream, but not yet released label Nov 12, 2019
@koekeishiya
Copy link
Owner

The zoom-state should now properly reset when a window is removed or added.
I could not reproduce the cases where resizing the window caused a false positive for the zoom-state.

@malfario
Copy link
Author

It's fixed, thanks a lot!

@koekeishiya koekeishiya removed the addressed on master; not released Fixed upstream, but not yet released label Nov 29, 2019
brorbw pushed a commit to brorbw/yabai that referenced this issue Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants