Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows randomly get shrunk #289

Closed
eramdam opened this issue Oct 20, 2019 · 14 comments
Closed

Windows randomly get shrunk #289

eramdam opened this issue Oct 20, 2019 · 14 comments
Labels
bug Something isn't working

Comments

@eramdam
Copy link

eramdam commented Oct 20, 2019

  • yabai 2.0.1
  • macOS 10.14.6

Sometimes (but it's not consistent and I can't make it what triggers it, nothing comes out in yabai's logs) the window that needs to be focused after another window is removed from a space gets shrunk to a very small size but the space it would take is still allocated. The only workaround I found when this happens is to swap another window with the shrunk one or, in the worst cases, reset the layout of the space.

Screen Shot 2019-10-19 at 10 09 13 PM

Sorry for the non very descriptive issue but that's all I have 🙇

@synthetiv
Copy link

I've had this happen a few times too. FWIW, I can only remember it happening to Firefox windows, and that looks like FF in your screenshot as well. Like you say, it seems to be a very temporary problem -- I think I've fixed it in the past by just toggling zoom-parent or float on the tiny window.

@eramdam
Copy link
Author

eramdam commented Oct 20, 2019

Hum, I've definitely seen this happen to other apps like VSCode so I don't think it's somehow specific to Firefox.

@koekeishiya
Copy link
Owner

Sounds like a bug, but I'm going to need steps to reproduce before I can do anything about this, as I have not experienced this problem in my day to day usage.

@eramdam
Copy link
Author

eramdam commented Oct 29, 2019

I don't have real repro steps. I'll try to be cautious of what I'm doing/what situation I'm in when this happens and report back here.

@eramdam
Copy link
Author

eramdam commented Oct 29, 2019

@koekeishiya is there perhaps some way to have yabai logs to be more verbose? I'm thinking maybe we might see something there when this happens.

@koekeishiya
Copy link
Owner

If you are running with the --verbose launch argument you already have max logging output.

@eramdam
Copy link
Author

eramdam commented Oct 29, 2019

If you are running with the --verbose launch argument you already have max logging output.

I didn't know about that flag! I'll run yabai with that flag and try to scoop the logs the next time this bug happens.

@eramdam
Copy link
Author

eramdam commented Nov 5, 2019

Okay, I finally managed to catch that bug while having verbose logs. Here's a gist with the relevant logs https://gist.github.com/eramdam/9190489024613b4ae6a65ba8f773a93f

The log is a bit noisy because of my Ubersitch widgets requesting the spaces information every few seconds but hopefully that can help trace down what's happening exactly when that bug happens.

Weirdly enough, this time the window was shrunk only horizontally (very tall and narrow) instead of being shrunk to a small square? 🤷‍♂

@koekeishiya koekeishiya added the bug Something isn't working label Nov 6, 2019
@koekeishiya
Copy link
Owner

I'm 96% certain this is caused by usage of parent/fullscreen zoom. What happens is that when a window in a nested tree is zoomed, and the upper-part of the tree is modified by adding or removing nodes, we end up in a situation where it is possible for the zoomed window' pointer to become invalid, yet it is not being reset.

@koekeishiya
Copy link
Owner

koekeishiya commented Nov 12, 2019

The issue regarding zoom interaction has been fixed on master. I'll assume that was the issue in this case (based on the previous debug logs). If you could run from master for some time and let me know if this issue occur for you again, or stop occurring (after x amount of days/weeks).

@koekeishiya koekeishiya added the addressed on master; not released Fixed upstream, but not yet released label Nov 12, 2019
@eramdam
Copy link
Author

eramdam commented Nov 12, 2019

@koekeishiya I'll try that and let you know how it goes!

@eramdam
Copy link
Author

eramdam commented Nov 12, 2019

Completely unrelated but I want to flag this so it doesn't fly above someone's head.

I had a pretty scary/weird issue where, if yabai 2.1.x doesn't have the Accessibility permission it...seems to completely freeze the window server and basically the whole macOS GUI stops responding to click/keyboard events? I can't tell yet if it's either yabai, skhd or a weird combination of the two but I had this happen on my home machine (2.1.0) on which I didn't do anything except upgrade yabai) and my laptop (master) on which I (stupidly :P ) removed the yabai binary from the accessibility permissions, not noticing that it tried to launch at the same time.

Maybe I was just unlucky and that report can be discarded but just wanted to flag this out just in case because it's kinda disturbing when it happens.

@eramdam
Copy link
Author

eramdam commented Nov 26, 2019

@koekeishiya I haven't seen the issue even since I started running off master. I think we can close it, thanks for investigating/fixing this issue 🙇

@koekeishiya
Copy link
Owner

I haven't seen the issue even since I started running off master. I think we can close it, thanks for investigating/fixing this issue 🙇

That's great.

I had a pretty scary/weird issue where, if yabai 2.1.x doesn't have the Accessibility permission it...seems to completely freeze the window server and basically the whole macOS GUI stops responding to click/keyboard events?

I have actually not had this happen with yabai and/or skhd, but i have seen this with other applications that require accessibility access. The only fix I had was to force-shutdown my mac using the powerbutton.

I did however manage to reliably reproduce the problematic situation with the following steps:

  1. Grant w/e application access to the accessibility API.
  2. Launch application that requires accessibility access, and leave it running.
  3. While the application is still running, uncheck the box in the accessbility permissions window.
  4. Force-shutdown mac.

I don't know if these same steps will trigger this issue for every system or even every application, but it did happen every time with the application i was testing for.

I don't actually know what can be done to prevent this from happening.

@koekeishiya koekeishiya removed the addressed on master; not released Fixed upstream, but not yet released label Nov 29, 2019
brorbw pushed a commit to brorbw/yabai that referenced this issue Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants