Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Borders don't follow window movement #617

Closed
peppy opened this issue Jul 20, 2020 · 4 comments
Closed

Borders don't follow window movement #617

peppy opened this issue Jul 20, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@peppy
Copy link

peppy commented Jul 20, 2020

Reproduction:

  • Set window border to >0px
  • Swap windows using (in the example yabai -m window --swap west)
  • Border's "shadow"(?) portion doesn't follow the movement and sticks to the wrong window.

2020-07-20 10 59 57

In the example I've made the width very thick to better show the issue. I do two swaps west then one swap east.

@koekeishiya
Copy link
Owner

koekeishiya commented Jul 22, 2020

What the heck, borders are not supposed to have shadows. Guess I never noticed because I run with window_shadow off and that also removed the shadow of the border window created by yabai, or maybe I just never noticed due to using a rather small width.

@koekeishiya koekeishiya added the bug Something isn't working label Jul 22, 2020
@koekeishiya koekeishiya added the addressed on master; not released Fixed upstream, but not yet released label Jul 22, 2020
@peppy
Copy link
Author

peppy commented Jul 23, 2020

The weird part is, it still happens with window_shadow turned off (the active border doesn't have a shadow, but the "ghost" one does:

IMG_0657

@koekeishiya
Copy link
Owner

I misspoke earlier. Borders created by yabai are not affected by the window_shadow setting. Made a change to master that explicitly disables the shadow when the border window is created, and that seemed to fix the issue for me.

@peppy
Copy link
Author

peppy commented Jul 24, 2020

Tested head, works perfectly. Thanks!

@peppy peppy closed this as completed Jul 24, 2020
@koekeishiya koekeishiya removed the addressed on master; not released Fixed upstream, but not yet released label Sep 3, 2020
unrevre pushed a commit to unrevre/yabai that referenced this issue Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants