koekeishiya#617 border windows should not have shadows

unrevre · Jul 22, 2020 · 2669946 · 2669946
1 parent f2ea10f
commit 2669946
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
 - Fixed an issue that caused a window to not become unmanaged when a space with a single window changed to float [#586](https://github.com/koekeishiya/yabai/issues/586)
 - Restore opacity back to full if *window_opacity* is disabled [#585](https://github.com/koekeishiya/yabai/issues/585)
 - Update scripting-addition to support macOS Big Sur 10.16 Build 20A4299v [#589](https://github.com/koekeishiya/yabai/issues/589)
+- Border windows should not have shadows [#617](https://github.com/koekeishiya/yabai/issues/617)
 
 ## [3.2.1] - 2020-06-17
 ### Changed

diff --git a/src/border.c b/src/border.c
@@ -76,7 +76,7 @@ void border_create(struct window *window)
     window->border.path = CGPathCreateMutable();
     CGPathAddRoundedRect(window->border.path, NULL, window->border.frame, 0, 0);
 
-    uint64_t tags = kCGSIgnoreForEventsTagBit;
+    uint64_t tags = kCGSIgnoreForEventsTagBit | kCGSDisableShadowTagBit;
     SLSNewWindow(g_connection, 2, 0, 0, window->border.region, &window->border.id);
     SLSSetWindowTags(g_connection, window->border.id, &tags, 64);
     SLSSetWindowResolution(g_connection, window->border.id, 1.0f);

diff --git a/src/border.h b/src/border.h
@@ -15,6 +15,7 @@ extern CGError CGSNewRegionWithRect(CGRect *rect, CFTypeRef *outRegion);
 
 #define kCGSIgnoreForExposeTagBit (1 << 7)
 #define kCGSIgnoreForEventsTagBit (1 << 9)
+#define kCGSDisableShadowTagBit   (1 << 3)
 
 struct border
 {

diff --git a/src/view.c b/src/view.c
@@ -13,7 +13,7 @@ void insert_feedback_show(struct window_node *node)
     CGSNewRegionWithRect(&frame, &frame_region);
 
     if (!node->feedback_window.id) {
-        uint64_t tags = kCGSIgnoreForExposeTagBit | kCGSIgnoreForEventsTagBit;
+        uint64_t tags = kCGSIgnoreForExposeTagBit | kCGSIgnoreForEventsTagBit | kCGSDisableShadowTagBit;
         SLSNewWindow(g_connection, 2, 0, 0, frame_region, &node->feedback_window.id);
         SLSSetWindowTags(g_connection, node->feedback_window.id, &tags, 64);
         SLSSetWindowResolution(g_connection, node->feedback_window.id, 1.0f);