-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Files in the target folder are being analyzed for builtin provider rules #358
Comments
I don't know if I would consider this a bug, we are finding real things in the project layout. We could give users some way to filter out specific directories using the built-in provider, but as this does not exist, I worry that this is another feature that needs to be added. |
@shawn-hurley this is mainly producing duplicate incidents, so I think it's not a huge problem. But at some point we'll probably have to fix it. |
I hit this with https://github.com/deewhyweb/eap-coolstore-monolith/tree/main What surprised me is I didn't intentionally compile the application, so was confused when I saw references to a 'target' directory. I now assume that during analysis the target directory was created and hence analyzed. The real thing that threw me off with this is I was programmatically grabbing the files from Git that the analyzer flagged as an issue, and when I hit the 'target/*' files they were not in Git so I threw an exception in my code. For now I'll just work around this
|
We should filter out results coming from |
Updating filecontent condition to exclude files in "target" subdirectory. This condition already used grep, so adding --exclude-dir option there. Fixes konveyor#358
Updating filecontent condition to exclude files in "target" subdirectory. This condition already used grep, so adding --exclude-dir option there. Fixes konveyor#358 Signed-off-by: Marek Aufart <[email protected]>
@jmle @shawn-hurley @pranavgaikwad I've been consistently reproducing this with multiple apps. An example of that can be seen with the properties file from the tackle-testapp application, the Hardcoded IP issue gets triggered twice, both in the application directory and under the target directory. |
This issue is currently awaiting triage. |
I assume this is because of the builtin provider not excluding this directory, while the java LS and stuff is (AFAIK) now not searching there. @eemcmullan if we can, we should wait for the PR that I have in flight because I am making some changes here. |
Is there an existing issue for this?
Konveyor version
0.3.0-alpha.5
Priority
Major
Current Behavior
Duplicate entries are appearing because some files inside the
target
folder are being analyzed.Expected Behavior
When analyzing a source code project with "source only", the
target
folder appearing as a result of running maven compilation should not be included in the analysis.How Reproducible
Always (Default)
Steps To Reproduce
javaee-to-jakarta-namespaces-00002
.target
folder are included:Environment
Anything else?
No response
The text was updated successfully, but these errors were encountered: