Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Skip "target" folder in file analysis #446

Closed
wants to merge 1 commit into from

Conversation

aufi
Copy link
Member

@aufi aufi commented Dec 6, 2023

Updating filecontent condition to exclude files in "target" subdirectory. This condition already used grep, so adding --exclude-dir option there.

Fixes #358

@aufi aufi changed the title Skip "target" folder in file analysis 🐛 Skip "target" folder in file analysis Dec 6, 2023
@aufi
Copy link
Member Author

aufi commented Dec 6, 2023

@jmle I'm not sure such simple fix is appropriate here, thinking about listing target directories first and check they are not in git, so were likely generated recently and should be skipped. (and if there is no git repo, skip target automatically or do some changed timestamp check?)

Updating filecontent condition to exclude files in "target"
subdirectory. This condition already used grep, so adding --exclude-dir
option there.

Fixes konveyor#358

Signed-off-by: Marek Aufart <[email protected]>
@aufi aufi closed this Jan 16, 2024
@aufi aufi reopened this Jan 16, 2024
@jmle
Copy link
Contributor

jmle commented Jan 16, 2024

Hey @aufi, sorry I somehow missed this one last month. The main problem I see with this approach is that the filecontent condition is in the internal provider, and therefore not exclusive to Java, but the target problem will only happen in Java. I'm also wondering if this problem is exclusive to the filecontent condition, or could also appear for instance with the javaclass conditions.

@shawn-hurley
Copy link
Contributor

@aufi Hey,

So I am going to close this, it was fixed in a different way in PR #534

Please let me know if you think that this is not correct or if this fixes something else and we can reopen

@aufi
Copy link
Member Author

aufi commented Mar 19, 2024

#534 covers this issue, so no problem with closing this PR, thanks Shawn!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Files in the target folder are being analyzed for builtin provider rules
3 participants