✨ Adjust resource requirements. #373
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Ortel <[email protected]>
shawn-hurley
reviewed
Aug 1, 2024
| @@ -176,7 +176,7 @@ provider_java_component_name: "extension" | |||
| provider_java_container_limits_cpu: "1" | |||
| provider_java_container_limits_memory: "2Gi" | |||
| provider_java_container_requests_cpu: "1" | |||
| provider_java_container_requests_memory: "2Gi" | |||
| provider_java_container_requests_memory: "1Gi" | |||
There was a problem hiding this comment.
This should stay at 2GI for the request the JVM will use 70% of max memory, and means that we can assume that it will use the full amount IMO. It will be safer to set this limit equal to the requests
|
Looks like requested resources have already been adjusted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resource requirements for the analyzer and providers can be lowered. This will support better scaling. Also, for the java provider, the JDK will not use 2Gi.
Scale testing has shown the hub memory spike to 2.3Gi with 3k applications being analyzed as fast as possible. Recommend limit should be bumped.
NOTE: I have some real concerns about large differences between request/limit. I'm concerned about oversubscribing the nodes when launching hundreds/thousands of pods without a Resource Quota. k8s does not seem to protect itself (nodes) against this.
Can the builtin requirements be lower?