Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Adjust resource requirements. #373

Closed
wants to merge 1 commit into from
Closed

✨ Adjust resource requirements. #373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions roles/tackle/defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ hub_deployment_replicas: "1"
hub_deployment_strategy: "Recreate"
hub_container_name: "{{ hub_service_name }}"
hub_container_limits_cpu: "1"
hub_container_limits_memory: "2Gi"
hub_container_limits_memory: "3Gi"
hub_container_requests_cpu: "500m"
hub_container_requests_memory: "1Gi"
hub_database_filename: "hub.db"
Expand Down Expand Up @@ -167,7 +167,7 @@ provider_generic_component_name: "extension"
provider_generic_container_limits_cpu: "1"
provider_generic_container_limits_memory: "1Gi"
provider_generic_container_requests_cpu: "1"
provider_generic_container_requests_memory: "1Gi"
provider_generic_container_requests_memory: "512Mi"
provider_generic_image_fqin: "{{ lookup('env', 'RELATED_IMAGE_PROVIDER_GENERIC') }}"
provider_generic_name: "generic"
provider_generic_service_name: "{{ app_name }}-{{ provider_generic_name }}-{{ analyzer_component_name }}"
Expand All @@ -176,7 +176,7 @@ provider_java_component_name: "extension"
provider_java_container_limits_cpu: "1"
provider_java_container_limits_memory: "2Gi"
provider_java_container_requests_cpu: "1"
provider_java_container_requests_memory: "2Gi"
provider_java_container_requests_memory: "1Gi"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should stay at 2GI for the request the JVM will use 70% of max memory, and means that we can assume that it will use the full amount IMO. It will be safer to set this limit equal to the requests

provider_java_image_fqin: "{{ lookup('env', 'RELATED_IMAGE_PROVIDER_JAVA') }}"
provider_java_name: "java"
provider_java_service_name: "{{ app_name }}-{{ provider_java_name }}-{{ analyzer_component_name }}"
Expand Down
Loading