[PF5 Regression] Active styles on sidebar nav items disappear when clicking elsewhere #1165
Assignees
Labels
Comments
gitdallas
added a commit
that referenced
this issue
Jul 21, 2023
## Missing Pencil on tables closes #1166 Also found several `pf-v5-m-` where the version should not be on the modifiers. This affected many items, such as not adding the blue left border to active menu items on the nav panel Aside from removing the `-v5` from `pf-m` modifiers, for the table I also removed the `inline-edit` div as it doesn't appear we are doing inline edits and the styling for the inline-edit was basically just being removed manually by the `enable` modifier. should also closes #1165 <!-- ## PR Title Prefix Every **PR Title** should be prefixed with :text: to indicate its type. - Breaking change:⚠️ (`⚠️ `) - Non-breaking feature: ✨ (`✨`) - Patch fix: 🐛 (`🐛`) - Docs: 📖 (`📖`) - Infra/Tests/Other: 🌱 (`🌱`) - No release note: 👻 (`👻`) For example, a pull request containing breaking changes might look like `⚠️ My pull request contains breaking changes`. Since GitHub supports emoji aliases (ie. `👻`), there is no need to include the emoji directly in the PR title -- **please use the alias**. It used to be the case that projects using emojis for PR typing had to include the emoji directly because GitHub didn't render the alias. Given that `⚠️ ` is easy enough to read as text, easy to parse in release tooling, and rendered in GitHub well, we prefer to standardize on the alias. For more information, please see the Konveyor [Versioning Doc](https://github.com/konveyor/release-tools/blob/main/VERSIONING.md). --> --------- Signed-off-by: gitdallas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
activeClassNameis removed from the active sidebar nav item when you click somewhere in the<main>area of the app viewport. The nav item should remain with active styles until you navigate to a page that is not nested under that section.It also appears that the blue bar present on the left side of the active nav item has gone away, although I'm not sure if that was intentional in PF.
PF4:
PF5:
The text was updated successfully, but these errors were encountered: