Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 (various): styling issues with pf-v5-m vs pf-m #1177

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

gitdallas
Copy link
Collaborator

@gitdallas gitdallas commented Jul 20, 2023

Missing Pencil on tables

closes #1166

Also found several pf-v5-m- where the version should not be on the modifiers. This affected many items, such as not adding the blue left border to active menu items on the nav panel

Aside from removing the -v5 from pf-m modifiers, for the table I also removed the inline-edit div as it doesn't appear we are doing inline edits and the styling for the inline-edit was basically just being removed manually by the enable modifier.

should also closes #1165

@gitdallas gitdallas changed the title fix(various): styling issues with pf-v5-m vs pf-m 🐛 (various): styling issues with pf-v5-m vs pf-m Jul 20, 2023
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (43e6f16) 44.09% compared to head (632dd82) 44.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1177   +/-   ##
=======================================
  Coverage   44.09%   44.09%           
=======================================
  Files         177      177           
  Lines        4499     4499           
  Branches     1007     1007           
=======================================
  Hits         1984     1984           
  Misses       2504     2504           
  Partials       11       11           
Flag Coverage Δ
unitests 44.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/src/app/common/KeyDisplayToggle.tsx 100.00% <ø> (ø)
client/src/app/components/target-card.tsx 20.96% <ø> (ø)
client/src/app/layout/SidebarApp/SidebarApp.tsx 26.66% <ø> (ø)
...ages/applications/analysis-wizard/custom-rules.tsx 14.09% <ø> (ø)
...s/components/application-form/application-form.tsx 55.98% <ø> (ø)
...pp-table-with-controls/app-table-with-controls.tsx 42.85% <ø> (ø)
...hared/components/horizontal-nav/horizontal-nav.tsx 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@gildub gildub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gitdallas !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants