Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Scrollable Modal - Visible Primary and Secondary Button #1708

Closed
1 task done
JustinXHale opened this issue Feb 27, 2024 · 3 comments · Fixed by #1776
Closed
1 task done

[BUG] Scrollable Modal - Visible Primary and Secondary Button #1708

JustinXHale opened this issue Feb 27, 2024 · 3 comments · Fixed by #1776
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Milestone

Comments

@JustinXHale
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Konveyor version

Feb 27, 2024

Priority

Minor

Current Behavior

When scrolling in a modal the Primary and Secondary action buttons should always be visible.
image

Expected Behavior

Primary & Secondary buttons should be visible. PF Example

image

How Reproducible

Always (Default)

Steps To Reproduce

Will apply to ever modal

Modal example

  1. Application inventory
  2. Create new

Environment

- OS:

Anything else?

No response

@JustinXHale JustinXHale added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 27, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added the needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. label Feb 27, 2024
@rszwajko
Copy link
Collaborator

@JustinXHale
We have a lot of content inside this modal - it is possible to just pin the buttons as you requested but perhaps it's time to move it to a subpage?
Quick draft looks the following: Screencast from 2024-03-13 20-06-35.webm

@JustinXHale
Copy link
Member Author

@JustinXHale We have a lot of content inside this modal - it is possible to just pin the buttons as you requested but perhaps it's time to move it to a subpage? Quick draft looks the following: Screencast from 2024-03-13 20-06-35.webm

you make a good point. I think this is something we need to look at across the product to make sure everything aligns with the interactions the user expects across the board. Part of me says your right, the other half says though its somewhat long a full page isnt needed b/c the user doesnt actually have to fill in all that information. This is definitely something I will look at as I continue the audit

@sjd78 sjd78 added this to the v0.3.1 milestone Mar 14, 2024
rszwajko added a commit to rszwajko/tackle2-ui that referenced this issue Mar 18, 2024
Split ApplicationForm into a data hook and view component.
Use extracted submit and cancel actions inside Modal's footer.

Resolves: konveyor#1708
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
rszwajko added a commit to rszwajko/tackle2-ui that referenced this issue Mar 19, 2024
Split ApplicationForm into a data hook and view component.
Use extracted submit and cancel actions inside Modal's footer.

Resolves: konveyor#1708
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
rszwajko added a commit to rszwajko/tackle2-ui that referenced this issue Mar 19, 2024
Split ApplicationForm into a data hook and view component.
Use extracted submit and cancel actions inside Modal's footer.

Resolves: konveyor#1708
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
rszwajko added a commit to rszwajko/tackle2-ui that referenced this issue Mar 21, 2024
Split ApplicationForm into a data hook and view component.
Use extracted submit and cancel actions inside Modal's footer.

Resolves: konveyor#1708
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
rszwajko added a commit to rszwajko/tackle2-ui that referenced this issue Mar 22, 2024
Split ApplicationForm into a data hook and view component.
Use extracted submit and cancel actions inside Modal's footer.

Resolves: konveyor#1708
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
ibolton336 added a commit that referenced this issue Mar 22, 2024
Split ApplicationForm into a data hook and view component. Use extracted
submit and cancel actions inside Modal's footer.

Resolves: #1708

---------

Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Co-authored-by: Ian Bolton <[email protected]>
github-actions bot pushed a commit that referenced this issue Mar 22, 2024
Split ApplicationForm into a data hook and view component. Use extracted
submit and cancel actions inside Modal's footer.

Resolves: #1708

---------

Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Co-authored-by: Ian Bolton <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
ibolton336 added a commit that referenced this issue Mar 22, 2024
Split ApplicationForm into a data hook and view component. Use extracted
submit and cancel actions inside Modal's footer.

Resolves: #1708

---------

Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Co-authored-by: Ian Bolton <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>

Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
Co-authored-by: Radoslaw Szwajkowski <[email protected]>
Co-authored-by: Ian Bolton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants