🐛 Decouple form actions from ApplicationForm #1776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rszwajko
force-pushed
the
scrollInNewApp
branch
from
fd48938
to
8bd5e7e
Compare
After
|
ibolton336
reviewed
Mar 18, 2024
client/src/app/pages/applications/components/application-form/application-form.tsx
Outdated
Show resolved
Hide resolved
rszwajko
force-pushed
the
scrollInNewApp
branch
2 times, most recently
from
6d892b9
to
25545b1
Compare
sjd78
reviewed
Mar 20, 2024
client/src/app/pages/applications/components/application-form/application-form-modal.tsx
Outdated
Show resolved
Hide resolved
ibolton336
added
the
cherry-pick/release-0.3
rszwajko
force-pushed
the
scrollInNewApp
branch
from
e93423b
to
f727b25
Compare
sjd78
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
After looking at what the createPortal-to-a-ref-in-the-Modal-footer would look like, and lots of discussion about it, the current setup is ok with me.
Going forward, we should think about if other tweaks to this approach would be good to apply across all form modals. I'm sure this will not be the last "keep the buttons sticky to the bottom" kind of request we will encounter.
|
For reference: version that uses portal to display buttons in the parent modal is available here -> rszwajko@ec93ae7 |
Split ApplicationForm into a data hook and view component. Use extracted submit and cancel actions inside Modal's footer. Resolves: konveyor#1708 Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
rszwajko
force-pushed
the
scrollInNewApp
branch
from
f727b25
to
02ff10d
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Mar 22, 2024
Split ApplicationForm into a data hook and view component. Use extracted submit and cancel actions inside Modal's footer. Resolves: #1708 --------- Signed-off-by: Radoslaw Szwajkowski <[email protected]> Co-authored-by: Ian Bolton <[email protected]> Signed-off-by: Cherry Picker <[email protected]>
ibolton336
added a commit
that referenced
this pull request
Mar 22, 2024
Split ApplicationForm into a data hook and view component. Use extracted submit and cancel actions inside Modal's footer. Resolves: #1708 --------- Signed-off-by: Radoslaw Szwajkowski <[email protected]> Co-authored-by: Ian Bolton <[email protected]> Signed-off-by: Cherry Picker <[email protected]> Signed-off-by: Radoslaw Szwajkowski <[email protected]> Signed-off-by: Cherry Picker <[email protected]> Co-authored-by: Radoslaw Szwajkowski <[email protected]> Co-authored-by: Ian Bolton <[email protected]>
This was referenced May 8, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split ApplicationForm into a data hook and view component. Use extracted submit and cancel actions inside Modal's footer.
Resolves: #1708