-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated dependency to [email protected] refs #70 #71
Conversation
Would really love to see this released, so we can unfork. |
@NilSet, Is there a public fork that I can use? |
No we just use fork we comitted inside our main repo. |
I would be interested in a public fork that has the module built and on npm (or a github repo) because without this I can't really move my project to node 10. :/ |
I was a bit tired of waiting so I made a fork of the built version : http://lab.shelter.moe/axelterizaki/node-sqlite In your package.json just replace the version number for the "sqlite" dependency like this : It's not ideal of course, but until this PR gets merged and a new version is published to NPM, this will do it for me at least. You're free to use it if you'd like. |
package.json
Outdated
@@ -50,7 +50,7 @@ | |||
} | |||
}, | |||
"dependencies": { | |||
"sqlite3": "4.0.0" | |||
"sqlite3": "4.0.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about "sqlite3": "^4.0.0"
? Then people will be able to use version they want...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4.0.0 and 4.0.1 have a flaw which prevents it from downloading the precompiled binary behind proxies. There's no practical reason to stay at 4.0.0 or 4.0.1. At least with 4.0.2 mentionned explicitely you're sure people who will only run npm install sqlite
will fetch the correct version.
Nice, thanks! :) |
This should fix #70
[email protected] uses a version of node-pre-gyp that requires needle to fetch pre-compiled sqlite3 binaries. Needle didn't play nice with people behind proxies, so the change has been reverted, causing a bump to sqlite3 to 4.0.2
My project uses sqlite and we can't upgrade to 2.9.2 because of this specific dependency. Merging this and creating a 2.9.3 version would be nice and allow us to upgrade to [email protected]
Thanks in advance