Updating dev tools #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @anis-campos, Thanks for taking the time to update all deps 🙏 Best |
hadeeb
reviewed
Apr 28, 2019
| @@ -1,4 +1,4 @@ | |||
| import Electron from "electron"; | |||
| import "electron"; | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
It can also be:
import * as electron from 'electron'; But at the end, the import here is just to link the types, there is no real execution of any electron code in this file. So as long as it compiles, it should be good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating devDependencies
Updating Babel config