Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating dev tools #9

Merged
merged 3 commits into from
Apr 22, 2019
Merged

Updating dev tools #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
367569b
Updating babel
anis-campos Apr 21, 2019
931a087
Accepting all electron >=2.0.9
anis-campos Apr 21, 2019
b2a9be2
No default export in electron
anis-campos Apr 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .babelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"presets": ["env"],
"plugins": ["transform-object-rest-spread"]
}
"presets": ["@babel/preset-env"],
"plugins": ["@babel/plugin-syntax-object-rest-spread"]
}
2 changes: 1 addition & 1 deletion index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import Electron from "electron";
import "electron";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be something like

import Electron = require("electron");

link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can also be:

import * as electron from 'electron';

But at the end, the import here is just to link the types, there is no real execution of any electron code in this file. So as long as it compiles, it should be good.


declare namespace EipHop {
export interface RequestObject<Payload> {
Expand Down
9 changes: 5 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,12 @@
},
"dependencies": {},
"devDependencies": {
"babel-cli": "^6.26.0",
"babel-plugin-transform-object-rest-spread": "^6.26.0",
"babel-preset-env": "^1.7.0"
"@babel/cli": "^7.4.3",
"@babel/core": "^7.4.3",
"@babel/plugin-syntax-object-rest-spread": "^7.2.0",
"@babel/preset-env": "^7.4.3"
},
"peerDependencies": {
"electron": "^2.0.9"
"electron": ">=2.0.9"
}
}
Loading