Skip to content

Commit

Permalink
fix(web-templates): use CleanedBasePath for titles (runatlantis#2091)
Browse files Browse the repository at this point in the history
A follow-up to runatlantis#2079

After upgrading to https://github.com/runatlantis/atlantis/releases/tag/v0.18.3 in our own
infra, I noticed a minor issue with the links in the titles, they are still pointing to /
even when '--atlantis-url' is provided.
  • Loading branch information
jvrplmlmn authored and krrrr38 committed Dec 16, 2022
1 parent c018b0f commit d64ebd2
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions server/controllers/templates/web_templates.go
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ var ProjectJobsTemplate = template.Must(template.New("blank.html.tmpl").Parse(`
<body>
<section class="header">
<a title="atlantis" href="/"><img class="hero" src="{{ .CleanedBasePath }}/static/images/atlantis-icon_512.png"/></a>
<a title="atlantis" href="{{ .CleanedBasePath }}"><img class="hero" src="{{ .CleanedBasePath }}/static/images/atlantis-icon_512.png"/></a>
<p class="title-heading">atlantis</p>
<p class="title-heading"><strong></strong></p>
</section>
Expand Down Expand Up @@ -461,7 +461,7 @@ var ProjectJobsErrorTemplate = template.Must(template.New("blank.html.tmpl").Par
<body>
<div class="container">
<section class="header">
<a title="atlantis" href="/"><img class="hero" src="{{ .CleanedBasePath }}/static/images/atlantis-icon_512.png"/></a>
<a title="atlantis" href="{{ .CleanedBasePath }}"><img class="hero" src="{{ .CleanedBasePath }}/static/images/atlantis-icon_512.png"/></a>
<p class="title-heading">atlantis</p>
<p class="title-heading"><strong></strong></p>
</section>
Expand Down Expand Up @@ -561,7 +561,7 @@ var GithubAppSetupTemplate = template.Must(template.New("github-app.html.tmpl").
<body>
<div class="container">
<section class="header">
<a title="atlantis" href="/"><img class="hero" src="{{ .CleanedBasePath }}/static/images/atlantis-icon_512.png"/></a>
<a title="atlantis" href="{{ .CleanedBasePath }}"><img class="hero" src="{{ .CleanedBasePath }}/static/images/atlantis-icon_512.png"/></a>
<p class="title-heading">atlantis</p>
<p class="js-discard-success"><strong>
Expand Down

0 comments on commit d64ebd2

Please sign in to comment.