fix(web-templates): use CleanedBasePath for static content

[jvrplmlmn]

When setting '--atlantis-url' this static content 404s.

For example, we can see this when comparig:

• /lock --> works seamless with a custom --atlantis-url
• /jobs --> doesn't work when using a custom --atlantis-url

Note that for the different templates, we are configuring CleanedBasePath: s.AtlantisURL.Path:

atlantis/server/server.go

Lines 879 to 884 in 58e9b42

	err = s.IndexTemplate.Execute(w, templates.IndexData{
	Locks: lockResults,
	ApplyLock: applyLockData,
	AtlantisVersion: s.AtlantisVersion,
	CleanedBasePath: s.AtlantisURL.Path,
	})

atlantis/server/controllers/locks_controller.go

Lines 82 to 94 in d914eaf

	viewData := templates.LockDetailData{
	LockKeyEncoded: id,
	LockKey: idUnencoded,
	PullRequestLink: lock.Pull.URL,
	LockedBy: lock.Pull.Author,
	Workspace: lock.Workspace,
	AtlantisVersion: l.AtlantisVersion,
	CleanedBasePath: l.AtlantisURL.Path,
	RepoOwner: owner,
	RepoName: repo,
	}
	err = l.LockDetailTemplate.Execute(w, viewData)

atlantis/server/controllers/jobs_controller.go

Lines 45 to 54 in 58e9b42

	viewData := templates.ProjectJobData{
	AtlantisVersion: j.AtlantisVersion,
	ProjectPath: jobID,
	CleanedBasePath: j.AtlantisURL.Path,
	}
	if err = j.ProjectJobsTemplate.Execute(w, viewData); err != nil {
	j.Logger.Err(err.Error())
	}
	}

Credit goes to @iainlane 👍

[inkel]

Thank you!

[jvrplmlmn]

I'm unsure if this changes are required, I generated this file via:

make dist

[chenrui333]

lgtm

[chenrui333]

Thanks @jvrplmlmn!