Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ES typo twenty-one something #127

Merged
merged 1 commit into from
Mar 29, 2016
Merged

Conversation

jlduran
Copy link
Collaborator

@jlduran jlduran commented Mar 29, 2016

This should fix a typo in Spanish, where twenty-one something (i.e. veintiún mil) was missing an accent.

The ES code could get some ❤️ as it is getting harder to debug. Fortunately, the tests are OK.

veintiun -> veintiún
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 4612f1f on jlduran:fix-es-typo into * on kslazarev:master*.

@miks miks merged commit c22bd08 into kslazarev:master Mar 29, 2016
@jlduran jlduran deleted the fix-es-typo branch March 29, 2016 18:49
@dblock
Copy link
Collaborator

dblock commented Mar 29, 2016

This fixes a bug and is missing a CHANGELOG entry, please.
https://github.com/kslazarev/numbers_and_words/blob/master/CHANGELOG.md

@jlduran
Copy link
Collaborator Author

jlduran commented Mar 29, 2016

Sure! I'll update the CHANGELOG.

jlduran added a commit that referenced this pull request Jun 11, 2017
Features

- Add full support for Brazilian Portuguese.  [#139]
- Add option `precision` to `to_words`.  [#134]

Bugs

- Fix README typo for 231 in French.
- Fix big numbers in Spanish.  [#129]
- Fix typo for number twenty-one in Spanish.  [#127]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants