add precision option #134

Neodelf · 2016-12-09T20:51:57Z

Add precision option to #to_words

coveralls · 2016-12-09T21:00:12Z

Coverage increased (+0.06%) to 99.88% when pulling 5ab7f1e on Neodelf:precision_option into 0c3a3af on kslazarev:master.

coveralls · 2016-12-09T21:00:12Z

Coverage increased (+0.06%) to 99.88% when pulling 5ab7f1e on Neodelf:precision_option into 0c3a3af on kslazarev:master.

coveralls · 2016-12-09T21:01:08Z

Coverage increased (+0.06%) to 99.88% when pulling 5ab7f1e on Neodelf:precision_option into 0c3a3af on kslazarev:master.

coveralls · 2016-12-09T21:01:08Z

Coverage increased (+0.06%) to 99.88% when pulling 5ab7f1e on Neodelf:precision_option into 0c3a3af on kslazarev:master.

dblock · 2016-12-09T21:58:34Z

How do I exercise this from code?

Neodelf · 2016-12-09T22:06:26Z

@dblock, you might execute 7.1.to_words(precision: 3)

dblock · 2016-12-10T14:29:28Z

I would add a test that calls that @Neodelf. Next this needs a README and a CHANGELOG update, please. And the build to pass.

dblock · 2016-12-10T14:30:22Z

I would just remove rbx from travis.
If a newer version of JRuby doesn't just work, remove that too.

Neodelf · 2016-12-10T17:17:16Z

@dblock you want to remove 'rbx' and 'jruby' versions in '.travis.yml`?
Tests covers new added code (but only russian version or is not true?). Yes, I will change README and CHANGELOG in very soon.

coveralls · 2016-12-10T18:00:09Z

Coverage increased (+0.06%) to 99.88% when pulling 6dd84ee on Neodelf:precision_option into 0c3a3af on kslazarev:master.

coveralls · 2016-12-10T18:00:09Z

Coverage increased (+0.06%) to 99.88% when pulling 6dd84ee on Neodelf:precision_option into 0c3a3af on kslazarev:master.

coveralls · 2016-12-10T18:04:13Z

Coverage increased (+0.06%) to 99.88% when pulling 3e28967 on Neodelf:precision_option into 0c3a3af on kslazarev:master.

coveralls · 2016-12-10T18:04:13Z

Coverage increased (+0.06%) to 99.88% when pulling 3e28967 on Neodelf:precision_option into 0c3a3af on kslazarev:master.

coveralls · 2016-12-10T18:06:33Z

Coverage increased (+0.06%) to 99.88% when pulling 421380f on Neodelf:precision_option into 0c3a3af on kslazarev:master.

coveralls · 2016-12-10T18:06:33Z

Coverage increased (+0.06%) to 99.88% when pulling 421380f on Neodelf:precision_option into 0c3a3af on kslazarev:master.

coveralls · 2016-12-10T18:08:22Z

Coverage increased (+0.06%) to 99.88% when pulling 421380f on Neodelf:precision_option into 0c3a3af on kslazarev:master.

coveralls · 2016-12-10T18:08:22Z

Coverage increased (+0.06%) to 99.88% when pulling 421380f on Neodelf:precision_option into 0c3a3af on kslazarev:master.

dblock · 2016-12-10T20:38:45Z

CHANGELOG.md


-  * Your contribution here.


Put this line back ;)

dblock · 2016-12-10T20:40:09Z

I just want the build to pass, and I don't care enough about JRuby and definitely not about RBX to waste your time. From tests it's not clear that you can do to_words(precision: ...), so I was hoping for one just like that in any language.

Neodelf · 2016-12-10T21:22:18Z

From tests it's not clear that you can do to_words(precision: ...)

I just followed convention about existed tests to order to new tests are easy to fit in existence

so I was hoping for one just like that in any language.

What do you suggest?

coveralls · 2016-12-10T21:32:44Z

Coverage increased (+0.06%) to 99.88% when pulling c35047f on Neodelf:precision_option into 0c3a3af on kslazarev:master.

coveralls · 2016-12-10T21:32:44Z

Coverage increased (+0.06%) to 99.88% when pulling c35047f on Neodelf:precision_option into 0c3a3af on kslazarev:master.

dblock · 2016-12-11T13:48:58Z

Looking at existing tests maybe I'm asking for something we don't need. I'm happy with the PR as long as you can please help fix the build?

coveralls · 2016-12-11T14:28:32Z

Coverage increased (+0.06%) to 99.88% when pulling 41bee13 on Neodelf:precision_option into 0c3a3af on kslazarev:master.

coveralls · 2016-12-11T14:28:32Z

Coverage decreased (-0.3%) to 99.52% when pulling 41bee13 on Neodelf:precision_option into 0c3a3af on kslazarev:master.

coveralls · 2016-12-11T16:28:00Z

Coverage decreased (-0.3%) to 99.52% when pulling bd95f1a on Neodelf:precision_option into 0c3a3af on kslazarev:master.

coveralls · 2016-12-11T21:21:21Z

Coverage increased (+0.06%) to 99.88% when pulling a8fed9f on Neodelf:precision_option into 0c3a3af on kslazarev:master.

coveralls · 2016-12-11T21:21:21Z

Coverage decreased (-0.3%) to 99.52% when pulling a8fed9f on Neodelf:precision_option into 0c3a3af on kslazarev:master.

dblock · 2016-12-12T05:06:09Z

Just remove rbx or add it to allow_failures, it's not worth it.

coveralls · 2016-12-12T07:27:46Z

Coverage decreased (-0.3%) to 99.52% when pulling 4ef2f89 on Neodelf:precision_option into 0c3a3af on kslazarev:master.

Neodelf · 2016-12-12T07:31:30Z

@dblock yes, I removed it)

jlduran · 2016-12-12T21:38:40Z

spec/numbers_and_words/float/fixture_examples/ru.yml

@@ -15,3 +15,16 @@ to_words:
    21.77: двадцать одна целая и семьдесят семь сотых
    111.999: сто одиннадцать целых и девятьсот девяносто девять тысячных
    4242.7463: четыре тысячи двести сорок двe целых и семь тысяч четыреста шестьдесят три десяти тысячных
+  fractions_with_precision:
+    options:
+      :precision: 2


Shouldn't this be precision: 2? (as well as the others)

Unfortunately, no

coveralls · 2016-12-12T21:54:08Z

Coverage increased (+0.06%) to 99.88% when pulling 87a8bc3 on Neodelf:precision_option into 0c3a3af on kslazarev:master.

coveralls · 2016-12-12T21:54:08Z

Coverage decreased (-0.3%) to 99.52% when pulling 87a8bc3 on Neodelf:precision_option into 0c3a3af on kslazarev:master.

update travis rubinius version

coveralls · 2016-12-12T22:02:11Z

Coverage increased (+0.06%) to 99.88% when pulling 7f5cabd on Neodelf:precision_option into 0c3a3af on kslazarev:master.

coveralls · 2016-12-12T22:02:11Z

Coverage decreased (-0.3%) to 99.52% when pulling 7f5cabd on Neodelf:precision_option into 0c3a3af on kslazarev:master.

jlduran · 2016-12-12T23:09:33Z

I made a couple minor suggestions, but it's OK as it is.

dblock · 2016-12-13T20:32:34Z

Merged.

Features - Add full support for Brazilian Portuguese. [#139] - Add option `precision` to `to_words`. [#134] Bugs - Fix README typo for 231 in French. - Fix big numbers in Spanish. [#129] - Fix typo for number twenty-one in Spanish. [#127]

Neodelf force-pushed the precision_option branch from 789e128 to 5ab7f1e Compare December 9, 2016 20:53

Neodelf force-pushed the precision_option branch from 3e28967 to 421380f Compare December 10, 2016 17:59

dblock reviewed Dec 10, 2016

View reviewed changes

Neodelf force-pushed the precision_option branch from 421380f to c35047f Compare December 10, 2016 21:24

Neodelf force-pushed the precision_option branch from a8fed9f to 4ef2f89 Compare December 12, 2016 07:22

jlduran reviewed Dec 12, 2016

View reviewed changes

Neodelf force-pushed the precision_option branch from 4ef2f89 to 87a8bc3 Compare December 12, 2016 21:49

Neodelf added 2 commits December 13, 2016 00:57

add precision option

fd44fbf

update travis settings

7f5cabd

update travis rubinius version

Neodelf force-pushed the precision_option branch from 87a8bc3 to 7f5cabd Compare December 12, 2016 21:57

dblock merged commit c24a2ed into kslazarev:master Dec 13, 2016

add precision option #134

add precision option #134

Conversation

Neodelf commented Dec 9, 2016

coveralls commented Dec 9, 2016

coveralls commented Dec 9, 2016

coveralls commented Dec 9, 2016

coveralls commented Dec 9, 2016

dblock commented Dec 9, 2016

Neodelf commented Dec 9, 2016

dblock commented Dec 10, 2016

dblock commented Dec 10, 2016

Neodelf commented Dec 10, 2016

coveralls commented Dec 10, 2016

coveralls commented Dec 10, 2016

coveralls commented Dec 10, 2016

coveralls commented Dec 10, 2016

coveralls commented Dec 10, 2016

coveralls commented Dec 10, 2016

coveralls commented Dec 10, 2016

coveralls commented Dec 10, 2016

dblock Dec 10, 2016

Choose a reason for hiding this comment

Neodelf Dec 10, 2016

Choose a reason for hiding this comment

dblock commented Dec 10, 2016

Neodelf commented Dec 10, 2016 • edited Loading

coveralls commented Dec 10, 2016

coveralls commented Dec 10, 2016

dblock commented Dec 11, 2016

coveralls commented Dec 11, 2016

coveralls commented Dec 11, 2016 • edited Loading

coveralls commented Dec 11, 2016 • edited Loading

coveralls commented Dec 11, 2016

coveralls commented Dec 11, 2016 • edited Loading

dblock commented Dec 12, 2016

coveralls commented Dec 12, 2016 • edited Loading

Neodelf commented Dec 12, 2016

jlduran Dec 12, 2016

Choose a reason for hiding this comment

Neodelf Dec 12, 2016 • edited Loading

Choose a reason for hiding this comment

coveralls commented Dec 12, 2016

coveralls commented Dec 12, 2016 • edited Loading

coveralls commented Dec 12, 2016

coveralls commented Dec 12, 2016 • edited Loading

jlduran commented Dec 12, 2016

dblock commented Dec 13, 2016

Neodelf commented Dec 10, 2016 •

edited

Loading

coveralls commented Dec 11, 2016 •

edited

Loading

coveralls commented Dec 11, 2016 •

edited

Loading

coveralls commented Dec 11, 2016 •

edited

Loading

coveralls commented Dec 12, 2016 •

edited

Loading

Neodelf Dec 12, 2016 •

edited

Loading

coveralls commented Dec 12, 2016 •

edited

Loading

coveralls commented Dec 12, 2016 •

edited

Loading