Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parking_lot requirement from 0.11 to 0.12 #799

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 31, 2022

Updates the requirements on parking_lot to permit the latest version.

Changelog

Sourced from parking_lot's changelog.

parking_lot 0.12.0, parking_lot_core 0.9.0, lock_api 0.4.6 (2022-01-28)

  • The MSRV is bumped to 1.49.0.
  • Disabled eventual fairness on wasm32-unknown-unknown. (#302)
  • Added a rwlock method to report if lock is held exclusively. (#303)
  • Use new asm! macro. (#304)
  • Use windows-rs instead of winapi for faster builds. (#311)
  • Moved hardware lock elision support to a separate Cargo feature. (#313)
  • Removed used of deprecated spin_loop_hint. (#314)

parking_lot 0.11.2, parking_lot_core 0.8.4, lock_api 0.4.5 (2021-08-28)

  • Fixed incorrect memory orderings on RwLock and WordLock. (#294, #292)
  • Added Arc-based lock guards. (#291)
  • Added workaround for TSan's lack of support for fence. (#292)

lock_api 0.4.4 (2021-05-01)

  • Update for latest nightly. (#281)

lock_api 0.4.3 (2021-04-03)

  • Added [Raw]ReentrantMutex::is_owned. (#280)

parking_lot_core 0.8.3 (2021-02-12)

  • Updated smallvec to 1.6. (#276)

parking_lot_core 0.8.2 (2020-12-21)

  • Fixed assertion failure on OpenBSD. (#270)

parking_lot_core 0.8.1 (2020-12-04)

  • Removed deprecated CloudABI support. (#263)
  • Fixed build on wasm32-unknown-unknown. (#265)
  • Relaxed dependency on smallvec. (#266)

parking_lot 0.11.1, lock_api 0.4.2 (2020-11-18)

  • Fix bounds on Send and Sync impls for lock guards. (#262)
  • Fix incorrect memory ordering in RwLock. (#260)

lock_api 0.4.1 (2020-07-06)

  • Add data_ptr method to lock types to allow unsafely accessing the inner data without a guard. (#247)

parking_lot 0.11.0, parking_lot_core 0.8.0, lock_api 0.4.0 (2020-06-23)

... (truncated)

Commits
  • a75875b Release parking_lot 0.12.0, parking_lot_core 0.9.0, lock_api 0.4.6
  • 78a16dd Minor fixes
  • 4d64bc6 Merge pull request #314 from Amanieu/spin_loop
  • a4e4a02 Only run CI for bors and pull requests
  • 930caab Use core::hint::spin_loop instead of the deprecated spin_loop_hint.
  • b3c9290 Merge pull request #313 from Amanieu/hle_feature
  • b271f84 Move hardware lock elision support to a separate Cargo feature
  • 8019473 Merge pull request #311 from clemenswasser/adopt-windows-rs
  • 1f94288 Adopt windows-rs
  • c73dd43 Merge pull request #309 from Amanieu/stable_asm
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies upgrades to dependencies label Jan 31, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2022

Codecov Report

Merging #799 (f93f6fa) into master (64e9ba3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #799   +/-   ##
=======================================
  Coverage   69.93%   69.93%           
=======================================
  Files          59       59           
  Lines        4145     4145           
=======================================
  Hits         2899     2899           
  Misses       1246     1246           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64e9ba3...f93f6fa. Read the comment docs.

@dependabot dependabot bot force-pushed the dependabot/cargo/parking_lot-0.12 branch from 1e8ac13 to 33d0c65 Compare January 31, 2022 10:41
@olix0r
Copy link
Contributor

olix0r commented Jan 31, 2022

I've started a discussion in Tokio about updating the version of parking_lot (which includes bumping the MSRV to 1.49). tokio-rs/tokio#4456

@clux
Copy link
Member

clux commented Jan 31, 2022

tempted to hold off on this for one version if it's undecided upstream - think we are pretty close to releasing the next version anyway - port forwarding pr in #446 looks ready

@olix0r
Copy link
Contributor

olix0r commented Jan 31, 2022

Agreed. Seems fine to pick this up when Tokio releases with the update

@dependabot dependabot bot force-pushed the dependabot/cargo/parking_lot-0.12 branch from 33d0c65 to 4ef437a Compare January 31, 2022 19:45
@olix0r
Copy link
Contributor

olix0r commented Jan 31, 2022

FYI, this will be included in the next Tokio release tokio-rs/tokio#4459

@clux clux added this to the 0.69.0 milestone Feb 1, 2022
@dependabot dependabot bot force-pushed the dependabot/cargo/parking_lot-0.12 branch from 4ef437a to 9daea07 Compare February 1, 2022 07:26
@clux clux added the blocked awaiting upstream work label Feb 1, 2022
@clux clux removed this from the 0.69.0 milestone Feb 11, 2022
@dependabot dependabot bot force-pushed the dependabot/cargo/parking_lot-0.12 branch from 9daea07 to f93f6fa Compare February 14, 2022 13:36
Updates the requirements on [parking_lot](https://github.com/Amanieu/parking_lot) to permit the latest version.
- [Release notes](https://github.com/Amanieu/parking_lot/releases)
- [Changelog](https://github.com/Amanieu/parking_lot/blob/master/CHANGELOG.md)
- [Commits](Amanieu/parking_lot@0.11.0...0.12.0)

---
updated-dependencies:
- dependency-name: parking_lot
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/cargo/parking_lot-0.12 branch from f93f6fa to c34f06e Compare February 14, 2022 15:54
@nightkr nightkr added this to the 0.70.0 milestone Feb 14, 2022
@clux
Copy link
Member

clux commented Feb 19, 2022

well, we have deny failures on parking_lot now anyway in master after #827, kube-client brings in parking_lot 0.12 via tokio 1.17

we can upgrade the kube_runtime pin, but we will still have deny failures the leaf that is pulled in from https://github.com/sfackler/hyper-openssl

    = parking_lot_core v0.8.5
      └── parking_lot v0.11.2
          ├── hyper-openssl v0.9.1
          │   └── kube-client v0.69.0

thinking this is a less detrimental duplicate to have (openssl case only) than the duplicate we currently already have (always, when using kube-runtime) - so we should probably just merge this and put a deny exclude or try to push a bump up to sfackler (the repo hasn't been updated in 14 months though)

@clux
Copy link
Member

clux commented Feb 19, 2022

made a pr upstream to hyper-openssl: sfackler/hyper-openssl#31

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 19, 2022

Looks like parking_lot is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Feb 19, 2022
@dependabot dependabot bot deleted the dependabot/cargo/parking_lot-0.12 branch February 19, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked awaiting upstream work dependencies upgrades to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants