Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scheduler::Error #827

Merged
merged 5 commits into from
Feb 14, 2022
Merged

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Feb 14, 2022

#826 neuters scheduler::Error into a void type (since DelayQueue is now infallible). This followup PR removes it completely, as well as any usages of it.

dependabot bot and others added 2 commits February 14, 2022 06:02
Updates the requirements on [tokio-util](https://github.com/tokio-rs/tokio) to permit the latest version.
- [Release notes](https://github.com/tokio-rs/tokio/releases)
- [Commits](https://github.com/tokio-rs/tokio/commits)

---
updated-dependencies:
- dependency-name: tokio-util
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Teo Klestrup Röijezon <[email protected]>
@nightkr nightkr added runtime controller runtime related changelog-change changelog change category for prs labels Feb 14, 2022
@nightkr nightkr requested a review from a team February 14, 2022 09:42
@nightkr nightkr self-assigned this Feb 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2022

Codecov Report

Merging #827 (45d87b0) into master (077e0f8) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #827      +/-   ##
==========================================
+ Coverage   69.92%   70.00%   +0.08%     
==========================================
  Files          58       58              
  Lines        3983     3977       -6     
==========================================
- Hits         2785     2784       -1     
+ Misses       1198     1193       -5     
Impacted Files Coverage Δ
kube-runtime/src/controller/mod.rs 0.00% <ø> (ø)
kube-runtime/src/controller/runner.rs 95.16% <100.00%> (+1.41%) ⬆️
kube-runtime/src/scheduler.rs 96.87% <100.00%> (+0.57%) ⬆️
kube-runtime/src/wait.rs 70.00% <0.00%> (+2.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 077e0f8...45d87b0. Read the comment docs.

This depends on kube-rs#826

Signed-off-by: Teo Klestrup Röijezon <[email protected]>
clux
clux previously approved these changes Feb 14, 2022
@clux clux added this to the 0.69.0 milestone Feb 14, 2022
@nightkr
Copy link
Member Author

nightkr commented Feb 14, 2022

@clux Is it fine to ignore the cargo-deny failures for now, or do we want to wait for the upstreams to release their own upgrades?

@clux
Copy link
Member

clux commented Feb 14, 2022

LGTM. duplicate dep from h2 via hyper tho.

Signed-off-by: Teo Klestrup Röijezon <[email protected]>
@clux
Copy link
Member

clux commented Feb 14, 2022

hm, to me, this one is probably OK to merge - i don't think we expose anything from tokio_util that will be needed by other users to pass to their tokio_util.

it would be nice to know when we can remove ignore directives though somehow :(

@nightkr
Copy link
Member Author

nightkr commented Feb 14, 2022

Cargo deny will start yelling once there are no more dependencies that match the skip clause. The downside is that this would probably only pop up in some completely unrelated PR...

@clux
Copy link
Member

clux commented Feb 14, 2022

I think it's also set to be a warning - so we would have to just catch it in the output atm.

@clux
Copy link
Member

clux commented Feb 14, 2022

let's put a pin in this until after a 0.69 release so we can merge all the ones that require cargo-deny overrides after that.

@clux clux dismissed their stale review February 14, 2022 11:39

holding on

@clux clux modified the milestones: 0.69.0, 0.70.0 Feb 14, 2022
@nightkr
Copy link
Member Author

nightkr commented Feb 14, 2022

@clux Are we ready to merge this now that 0.69 is out?

@clux
Copy link
Member

clux commented Feb 14, 2022

ah, yes, let's carry on :-)

@nightkr nightkr merged commit 4eb2d54 into kube-rs:master Feb 14, 2022
@nightkr nightkr deleted the chore/infallible-scheduler branch February 14, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-change changelog change category for prs runtime controller runtime related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants