Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new PR for XGBoost due to problems with history rewrite #232

Merged
merged 11 commits into from
Aug 22, 2018

Conversation

puneith
Copy link
Contributor

@puneith puneith commented Aug 22, 2018

@jlewi @texasmichelle I had to create a new PR due to history rewrite. See previous PR #27


This change is Reviewable

@jlewi
Copy link
Contributor

jlewi commented Aug 22, 2018

/lgtm
/approve

But looks like presubmit is failing

@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 22, 2018
@puneith
Copy link
Contributor Author

puneith commented Aug 22, 2018

@jlewi okay fixed.

@jlewi
Copy link
Contributor

jlewi commented Aug 22, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit bd07a2f into master Aug 22, 2018
yixinshi pushed a commit to yixinshi/examples that referenced this pull request Nov 30, 2018
* new PR for XGBoost due to problems with history rewrite

* Update housing.py

* Update HousingServe.py

* Update housing.py

* added bitly

* removed test function

* reorder imports

* fix spaces

* fix spaces

* fixed lint errors

* renamed to xgboost_ames_housing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants