Kaggle Ames xgboost #27
Conversation
Added mercari Kaggle competition entry
added example
Added Airbnb example
Added Airbnb Kaggle link
Add GitHub issue summarization example
edit license badge out
Adding TOC
Adding end-to-end example sequence to sequence learning per request from Jeremy Lewi
Move GitHub issue summarization example into a third_party folder since it is not Apache 2 licensed. Add LICENSE file from original repo: (https://github.com/hamelsmu/Seq2Seq_Tutorial) Remove redundancy in folder name
There was a problem hiding this comment.
I think if we leave the local serving (which works) and (currently broken GKE serving), and merge PR. Then do the fix in follow-up PR that will give folks to try out the XGBoost example which does indeed work (modulo GKE). I personally don't find it a terrible thing to do unless folks think otherwise.
Reviewable status: 0 of 9 files reviewed, 22 unresolved discussions (waiting on @ankushagarwal, @texasmichelle, @jlewi, and @puneith)
xgboost/README.md, line 54 at r23 (raw file):
Previously, texasmichelle (Michelle Casbon) wrote…
Insert "by running" before
docker images.
Done.
xgboost/README.md, line 62 at r23 (raw file):
Previously, texasmichelle (Michelle Casbon) wrote…
s/One/A/
Done.
xgboost/README.md, line 66 at r23 (raw file):
Previously, texasmichelle (Michelle Casbon) wrote…
This link is broken
Done.
xgboost/README.md, line 69 at r23 (raw file):
Previously, texasmichelle (Michelle Casbon) wrote…
Formatting issue - these are collapsed into a single line
Done.
xgboost/README.md, line 81 at r23 (raw file):
Previously, texasmichelle (Michelle Casbon) wrote…
Same formatting issue
Done.
xgboost/README.md, line 87 at r23 (raw file):
Previously, texasmichelle (Michelle Casbon) wrote…
sp *Persistent
Done.
xgboost/README.md, line 90 at r23 (raw file):
Previously, texasmichelle (Michelle Casbon) wrote…
s/at/to the/
Done.
xgboost/README.md, line 151 at r23 (raw file):
Previously, texasmichelle (Michelle Casbon) wrote…
There are several places where users are instructed to setup a GKE cluster, which is redundant. Let’s move them into the Prerequisites section, as well as Kubeflow Setup, so that it is all in one place.
Done.
xgboost/README.md, line 153 at r23 (raw file):
Previously, texasmichelle (Michelle Casbon) wrote…
s/minikube Kubernetes/GKE/
Insert "in the Deploy Seldon Core section" before [here].
Done.
xgboost/README.md, line 167 at r23 (raw file):
Previously, texasmichelle (Michelle Casbon) wrote…
sp *Deploy
Done.
xgboost/README.md, line 180 at r23 (raw file):
Previously, texasmichelle (Michelle Casbon) wrote…
sp *its
I must have been writing this in my sleep, thx! :) done
xgboost/README.md, line 187 at r23 (raw file):
Previously, texasmichelle (Michelle Casbon) wrote…
You're port forwarding 8080, then curling on 5000.
Done.
|
@texasmichelle @jlewi responded to comments. |
|
/retest all |
|
Agreed - let's merge what we have & create an issue for resolving the GKE approach. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: texasmichelle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@puneith Can you look into these merge blockers? |
puneith
force-pushed
the
xgboost_zillow
branch
from
febca60
to
885dbb0
Compare
|
New changes are detected. LGTM label has been removed. |
|
@texasmichelle hmm I didn't close the PR how did it do that? And now I can't reopen it. |
|
@puneith: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Moved the PR kubeflow/kubeflow#163 to here. Work in progress, DO NOT REVIEW.
Related to #16
This change is