[Bug Fix - new ui] : Fix bug on list type hp

[seong7]

What this PR does / why we need it:

This PR fixes a bug described below.

When user edits hyper parameters' type from 'int' or 'double' to 'Categorical' or 'Discrete' and save the values,

The page falls into infinite error loop.

This bug has been caused by this line in parameter.component.ts.

this.paramCtrl
    .get('feasibleSpace')
    .setValue(group.get('feasibleSpace').value);

The method setValue() of FormGroup throws when the new value is not exactly in the same structure of the existing FormControl.

This case, the existing Control has already been initialized as the structure below.
(This is the difference compared to 'adding a new param'. When adding, the error does not occur.)

{
  min: 1,
  max: 1, 
  step: ''
}

But the new value has a different structure as below.

{
  list: [ '111', '222' ]
}

To replace a Control in a FormGroup, we should use the method setControl() instead of setValue().

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

• Docs included if any changes are user facing

[google-oss-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: seong7
To complete the pull request process, please assign kimwnasptd after the PR has been reviewed.
You can assign the PR to them by writing /assign @kimwnasptd in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• pkg/new-ui/v1beta1/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[aws-kf-ci-bot]

Hi @seong7. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[anencore94]

/ok-to-test

[gaocegege]

Thanks for your contribution! 🎉 👍

/assign @andreyvelich

[andreyvelich]

Thank you for this fix @seong7!
/assign @kimwnasptd

[kimwnasptd]

The changes LTGM, also @seong7 very good job on describing the problem in the first message!

Could you only remove the changes in the package-lock.json file?

[coveralls]

Coverage increased (+1.6%) to 74.239% when pulling e5e3be3 on seong7:bugfix/list-type-hp into 983a867 on kubeflow:master.

[kimwnasptd]

Everything looks good, thanks for the work @seong7 and apologies for the delay!

/lgtm
/approve

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimwnasptd, seong7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/new-ui/v1beta1/OWNERS [kimwnasptd]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment