Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated variable from GRPC definitions #1994

Merged
merged 8 commits into from
Nov 3, 2022
Merged

Remove deprecated variable from GRPC definitions #1994

merged 8 commits into from
Nov 3, 2022

Conversation

johnugeorge
Copy link
Member

request_num is deprecated and needs to be removed.

Ref: #1728 (comment) #1993 (comment)

/cc @anencore94 @andreyvelich

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

coveralls commented Nov 2, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-0.01%) to 73.419% when pulling 47623d5 on johnugeorge:master into 570a3e6 on kubeflow:master.

@johnugeorge johnugeorge changed the title Remove deprecated variable from GRPC photo Remove deprecated variable from GRPC definitions Nov 3, 2022
@google-oss-prow google-oss-prow bot added size/XL and removed size/L labels Nov 3, 2022
@google-oss-prow google-oss-prow bot added size/L and removed size/XL labels Nov 3, 2022
@johnugeorge
Copy link
Member Author

/assign @tenzen-y

tenzen-y
tenzen-y reviewed Nov 3, 2022
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnugeorge Thanks for this!
/lgtm

Also, are you working on the reverted commit, Support for k8s v1.25 in CI in another PR?

@google-oss-prow google-oss-prow bot added the lgtm label Nov 3, 2022
@johnugeorge
Copy link
Member Author

@johnugeorge Thanks for this! /lgtm

Also, are you working on the reverted commit, Support for k8s v1.25 in CI in another PR?

@tenzen-y Yes. I will create a separate PR for it soon

@google-oss-prow google-oss-prow bot merged commit 4a2db41 into kubeflow:master Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@andreyvelich andreyvelich Awaiting requested review from andreyvelich

@anencore94 anencore94 Awaiting requested review from anencore94

Assignees

@tenzen-y tenzen-y

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnugeorge @coveralls @tenzen-y