Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated variable from GRPC definitions #1994

Merged
merged 8 commits into from
Nov 3, 2022
Merged

Remove deprecated variable from GRPC definitions #1994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1753314
Update training operator image in CI
johnugeorge Aug 19, 2022
c14b197
Merge remote-tracking branch 'upstream/master'
johnugeorge Nov 2, 2022
a6b7a36
Remove deprecated GRPC var
johnugeorge Nov 2, 2022
280b07b
Remove deprecated GRPC var
johnugeorge Nov 2, 2022
ccd4505
Remove deprecated GRPC var
johnugeorge Nov 2, 2022
b90e686
Merge remote-tracking branch 'upstream/master'
johnugeorge Nov 3, 2022
16e6fe4
Support for k8s v1.25 in CI
johnugeorge Nov 3, 2022
47623d5
Revert "Support for k8s v1.25 in CI"
johnugeorge Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
256 changes: 123 additions & 133 deletions pkg/apis/manager/v1beta1/api.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 0 additions & 3 deletions pkg/apis/manager/v1beta1/api.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,9 +293,6 @@ message DeleteObservationLogReply {
message GetSuggestionsRequest {
Experiment experiment = 1;
repeated Trial trials = 2; // All completed trials owned by the experiment.
// Use current_request_number instead. This API will be removed in Katib 0.14.
// The number of Suggestions requested at one time.
int32 request_number = 3 [deprecated=true];
// The number of Suggestions requested at one time.
// When you set 3 to current_request_number, you get three Suggestions at one time.
int32 current_request_number = 4;
Expand Down
1 change: 0 additions & 1 deletion pkg/apis/manager/v1beta1/gen-doc/api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,6 @@ Discrete and Categorical type use List.
| ----- | ---- | ----- | ----------- |
| experiment | [Experiment](#api-v1-beta1-Experiment) | | |
| trials | [Trial](#api-v1-beta1-Trial) | repeated | All completed trials owned by the experiment. |
| request_number | [int32](#int32) | | **Deprecated.** Use current_request_number instead. This API will be removed in Katib 0.14. The number of Suggestions requested at one time. |
| current_request_number | [int32](#int32) | | The number of Suggestions requested at one time. When you set 3 to current_request_number, you get three Suggestions at one time. |
| total_request_number | [int32](#int32) | | The number of Suggestions requested till now. |

Expand Down
29 changes: 0 additions & 29 deletions pkg/apis/manager/v1beta1/gen-doc/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1029,14 +1029,6 @@ <h3 id="api.v1.beta1.GetSuggestionsRequest">GetSuggestionsRequest</h3>
<td><p>All completed trials owned by the experiment. </p></td>
</tr>

<tr>
<td>request_number</td>
<td><a href="#int32">int32</a></td>
<td></td>
<td><p><strong>Deprecated.</strong> Use current_request_number instead. This API will be removed in Katib 0.14.
The number of Suggestions requested at one time. </p></td>
</tr>

<tr>
<td>current_request_number</td>
<td><a href="#int32">int32</a></td>
Expand All @@ -1056,27 +1048,6 @@ <h3 id="api.v1.beta1.GetSuggestionsRequest">GetSuggestionsRequest</h3>
</table>




<h4>Fields with deprecated option</h4>
<table>
<thead>
<tr>
<td>Name</td>
<td>Option</td>
</tr>
</thead>
<tbody>

<tr>
<td>request_number</td>
<td><p>true</p></td>
</tr>

</tbody>
</table>





Expand Down
85 changes: 38 additions & 47 deletions pkg/apis/manager/v1beta1/python/api_pb2.py
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 2 additions & 4 deletions pkg/controller.v1beta1/suggestion/suggestionclient/suggestionclient.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,8 @@ func (g *General) SyncAssignments(
instance.Status.AlgorithmSettings)

requestSuggestion := &suggestionapi.GetSuggestionsRequest{
Experiment: g.ConvertExperiment(filledE),
Trials: g.ConvertTrials(ts),
// TODO (andreyvelich): Remove this once RequestNumber is deprecated.
RequestNumber: int32(currentRequestNum),
Experiment: g.ConvertExperiment(filledE),
Trials: g.ConvertTrials(ts),
CurrentRequestNumber: int32(currentRequestNum),
TotalRequestNumber: int32(instance.Spec.Requests),
}
Expand Down
1 change: 0 additions & 1 deletion pkg/controller.v1beta1/suggestion/suggestionclient/suggestionclient_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -994,7 +994,6 @@ func newFakeRequest() *suggestionapi.GetSuggestionsRequest {
},
},
},
RequestNumber: 2,
CurrentRequestNumber: 2,
TotalRequestNumber: 6,
}
Expand Down