fixes 'add docker-for-desktop platform to kfctl (golang)' #2433

kkasravi · 2019-02-08T02:10:27Z

fixes #2420

this PR is based off of PR #2428

This change is

…nnet.go respectively

…ugins'

…to refactor_to_plugins

jlewi · 2019-02-10T18:55:32Z

Marking this as WIP until #2428 is merged.

ashahba

Thanks @kkasravi for the PR. Overall looks good just a few minor comments.

ashahba · 2019-02-10T22:23:02Z

bootstrap/Makefile

 	echo SUCCESS

 # generate all --email [email protected] --ipName 35.233.240.120
 test-known-platforms-generate: test-known-platforms-init
 	@cd ~/ksonnet && \
-	kfctl generate all -V && \
+	PLUGINS_ENVIRONMENT=$(GOPATH)/src/github.com/kubeflow/kubeflow/bootstrap/bin kfctl generate all -V && \


I'd just do:

PLUGINS_ENVIRONMENT=$(PLUGINS_ENVIRONMENT)

ashahba · 2019-02-10T22:23:19Z

bootstrap/Makefile

 	cd ~/minikube && \
-	kfctl generate all -V --mount-local && \
+	PLUGINS_ENVIRONMENT=$(GOPATH)/src/github.com/kubeflow/kubeflow/bootstrap/bin kfctl generate all -V --mount-local && \


same as above

ashahba · 2019-02-10T22:23:33Z

bootstrap/Makefile

-	kfctl generate all -V --mount-local && \
+	PLUGINS_ENVIRONMENT=$(GOPATH)/src/github.com/kubeflow/kubeflow/bootstrap/bin kfctl generate all -V --mount-local && \
+	cd ~/docker-for-desktop && \
+	PLUGINS_ENVIRONMENT=$(GOPATH)/src/github.com/kubeflow/kubeflow/bootstrap/bin kfctl generate all -V --mount-local && \


same as above

ashahba · 2019-02-10T22:23:50Z

bootstrap/Makefile

-	kfctl generate all -V --mount-local && \
+	PLUGINS_ENVIRONMENT=$(GOPATH)/src/github.com/kubeflow/kubeflow/bootstrap/bin kfctl generate all -V --mount-local && \
+	cd ~/docker-for-desktop && \
+	PLUGINS_ENVIRONMENT=$(GOPATH)/src/github.com/kubeflow/kubeflow/bootstrap/bin kfctl generate all -V --mount-local && \
 	cd ~/foo && \
 	PLUGINS_ENVIRONMENT=$(GOPATH)/src/github.com/kubeflow/kubeflow/bootstrap/bin kfctl generate all -V && \


same as above

ashahba · 2019-02-10T22:31:39Z

bootstrap/cmd/kfctl/README.md

+make debug
+```
+
+To go back to where plugins are loaded (this should be the default) run


Not sure about the wording but a better message would be a good idea

thanks Ebi - we're going to move most of the plugins back to a static configuration to minimize complexity. The PLUGINS_ENVIRONMENT will probably be set to a specific directory when we add the brew installer.

kkasravi

Reviewable status: 0 of 12 files reviewed, 5 unresolved discussions (waiting on @ashahba and @ellis-bigelow)

bootstrap/Makefile, line 107 at r4 (raw file):

Previously, ashahba (Abolfazl Shahbazi) wrote…

I'd just do:

PLUGINS_ENVIRONMENT=$(PLUGINS_ENVIRONMENT)

thanks - i think both are updated now

bootstrap/Makefile, line 109 at r4 (raw file):

Previously, ashahba (Abolfazl Shahbazi) wrote…

same as above

Done.

bootstrap/Makefile, line 111 at r4 (raw file):

Previously, ashahba (Abolfazl Shahbazi) wrote…

same as above

Done.

bootstrap/Makefile, line 113 at r4 (raw file):

Previously, ashahba (Abolfazl Shahbazi) wrote…

same as above

since we're removing some of the plugins and making them static the Makefile doesn't need the PLUGINS_ENVIRONMENT everywhere - but thanks. There are changes from the prior PR

kkasravi · 2019-02-12T16:09:29Z

/assign @ashahba

kkasravi · 2019-02-12T16:09:40Z

@jlewi @ashahba this is ready for review

kkasravi

Reviewable status: 0 of 8 files reviewed, 5 unresolved discussions (waiting on @ashahba and @ellis-bigelow)

bootstrap/Makefile, line 107 at r4 (raw file):

Previously, kkasravi (Kam Kasravi) wrote…

thanks - i think both are updated now

Done.

bootstrap/Makefile, line 113 at r4 (raw file):

Previously, kkasravi (Kam Kasravi) wrote…

since we're removing some of the plugins and making them static the Makefile doesn't need the PLUGINS_ENVIRONMENT everywhere - but thanks. There are changes from the prior PR

Done.

bootstrap/cmd/kfctl/README.md, line 231 at r4 (raw file):

Previously, kkasravi (Kam Kasravi) wrote…

thanks Ebi - we're going to move most of the plugins back to a static configuration to minimize complexity. The PLUGINS_ENVIRONMENT will probably be set to a specific directory when we add the brew installer.

Done.

jlewi

Reviewed 2 of 32 files at r1, 1 of 3 files at r3, 4 of 13 files at r5.
Reviewable status: 7 of 8 files reviewed, 6 unresolved discussions (waiting on @ashahba, @ellis-bigelow, and @kkasravi)

bootstrap/pkg/client/ksonnet/ksonnet.go, line 294 at r5 (raw file):

		}
	}
	name := "meta-controller-cluster-role-binding"

How come we need separate logic to delete this cluster role binding?

jlewi · 2019-02-14T04:06:29Z

just a thought

If you wanted a platform to experiment with the plugin model. docker-for-desktop might be a good one.
It looks like we don't have explicit instructions for it on the website
https://www.kubeflow.org/docs/

/cc @rogaha who added docker for desktop scripts in #1954

kkasravi

great idea, why don't i remove foo.go and move dockerfordesktop.go in it's place.

Reviewable status: 7 of 8 files reviewed, 6 unresolved discussions (waiting on @ashahba, @ellis-bigelow, and @jlewi)

bootstrap/pkg/client/ksonnet/ksonnet.go, line 294 at r5 (raw file):

Previously, jlewi (Jeremy Lewi) wrote…

How come we need separate logic to delete this cluster role binding?

it's an incomplete solution right now, I was starting to doing explicit deletes. kfctl needs to delete all cluster resources based on a list that currently is generated in the application component. We basically need to get this list from ksonnet. I'll fix under #2415.

kkasravi · 2019-02-14T14:37:13Z

@jlewi replaced foo with dockerfordesktop

jlewi · 2019-02-14T23:19:22Z

/lgtm
/approve
/hold for @ashahba

k8s-ci-robot · 2019-02-14T23:19:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~bootstrap/OWNERS~~ [jlewi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

) * revert to prior version * fixes kfctl (golang) rename 'ks' directory and app to ksonnet and ksonnet.go respectively * fixes 'kfctl - Fetch registry automatically' * fixes 'refactor gcp, minikube, docker-for-desktop, ack to be kfctl plugins' * change DefaultDevRepo to point to just the repo not repo/kubeflow * fixes 'refactor gcp, minikube, docker-for-desktop, ack to be kfctl plugins' * plugins for all existing KfApp instances {ksonnet, minikube, foo}. * update golang version * fixes 'docker-for-desktop' * delete meta-controller-cluster-role-binding * update README.md * remove unused var DEBUG * remove bootstrap/cmd/plugins/foo.go * merge changes from upstream master * remove old files, update README.md * removing foo, making dockerfordesktop a plugin * remove foo, make dockerfordesktop the plugin

Kam D Kasravi added 30 commits June 29, 2018 18:13

revert to prior version

47589db

Merge branch 'master' of github.com:kubeflow/kubeflow

9871589

Merge branch 'master' of github.com:kubeflow/kubeflow

4fbc3dd

Merge branch 'master' of github.com:kubeflow/kubeflow

9e3ed03

Merge branch 'master' of github.com:kubeflow/kubeflow

190aa45

Merge branch 'master' of github.com:kubeflow/kubeflow

0b3e680

Merge branch 'master' of github.com:kubeflow/kubeflow

271a090

Merge branch 'master' of github.com:kubeflow/kubeflow

7a41e5a

Merge branch 'master' of github.com:kubeflow/kubeflow

bcb5a70

Merge branch 'master' of github.com:kubeflow/kubeflow

c3695cd

Merge branch 'master' of github.com:kubeflow/kubeflow

689118c

Merge branch 'master' of github.com:kubeflow/kubeflow

59ef8a2

Merge branch 'master' of github.com:kubeflow/kubeflow

96cad9d

Merge branch 'master' of github.com:kubeflow/kubeflow

aa4ce38

Merge branch 'master' of github.com:kubeflow/kubeflow

4f9efbd

Merge branch 'master' of github.com:kubeflow/kubeflow

eeb0d95

Merge branch 'master' of github.com:kubeflow/kubeflow

0764065

Merge branch 'master' of github.com:kubeflow/kubeflow

856bdef

Merge branch 'master' of github.com:kubeflow/kubeflow

8992d16

Merge branch 'master' of github.com:kubeflow/kubeflow

1b98de6

Merge branch 'master' of github.com:kubeflow/kubeflow

8187167

Merge branch 'master' of github.com:kubeflow/kubeflow

b6a69dc

Merge branch 'master' of github.com:kubeflow/kubeflow

58bbef1

fixes kfctl (golang) rename 'ks' directory and app to ksonnet and kso…

81599b4

…nnet.go respectively

fixes 'kfctl - Fetch registry automatically'

2977aef

fixes 'refactor gcp, minikube, docker-for-desktop, ack to be kfctl pl…

d090f5f

…ugins'

change DefaultDevRepo to point to just the repo not repo/kubeflow

150db9f

fixes 'refactor gcp, minikube, docker-for-desktop, ack to be kfctl pl…

281d7f7

…ugins'

Merge branch 'refactor_to_plugins' of github.com:kkasravi/kubeflow in…

714c642

…to refactor_to_plugins

plugins for all existing KfApp instances {ksonnet, minikube, foo}.

88a7a45

k8s-ci-robot added the do-not-merge/work-in-progress label Feb 10, 2019

ashahba suggested changes Feb 10, 2019

View reviewed changes

merge changes from upstream master

f63dc6a

kkasravi force-pushed the dockerfordesktop branch from 0162a6c to f63dc6a Compare February 12, 2019 15:52

k8s-ci-robot added size/L and removed size/XL labels Feb 12, 2019

kkasravi changed the title ~~[WIP] fixes 'add docker-for-desktop platform to kfctl (golang)'~~ fixes 'add docker-for-desktop platform to kfctl (golang)' Feb 12, 2019

k8s-ci-robot removed the do-not-merge/work-in-progress label Feb 12, 2019

merge changes from upstream master

227d4d3

kkasravi commented Feb 12, 2019

View reviewed changes

remove old files, update README.md

23cab72

k8s-ci-robot assigned ashahba Feb 12, 2019

kkasravi commented Feb 13, 2019

View reviewed changes

jlewi suggested changes Feb 14, 2019

View reviewed changes

kkasravi commented Feb 14, 2019

View reviewed changes

Kam D Kasravi added 3 commits February 14, 2019 06:10

removing foo, making dockerfordesktop a plugin

a67b24d

Merge remote-tracking branch 'upstream/master' into dockerfordesktop

aaf515b

remove foo, make dockerfordesktop the plugin

ba1ea69

k8s-ci-robot added the lgtm label Feb 14, 2019

k8s-ci-robot added the approved label Feb 14, 2019

k8s-ci-robot merged commit 072c74f into kubeflow:master Feb 14, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixes 'add docker-for-desktop platform to kfctl (golang)' #2433

fixes 'add docker-for-desktop platform to kfctl (golang)' #2433

kkasravi commented Feb 8, 2019 •

edited by jlewi

Loading

jlewi commented Feb 10, 2019

ashahba left a comment

ashahba Feb 10, 2019

ashahba Feb 10, 2019

ashahba Feb 10, 2019

ashahba Feb 10, 2019

ashahba Feb 10, 2019

kkasravi Feb 12, 2019

kkasravi left a comment

kkasravi commented Feb 12, 2019

kkasravi commented Feb 12, 2019

kkasravi left a comment

jlewi left a comment

jlewi commented Feb 14, 2019

kkasravi left a comment

kkasravi commented Feb 14, 2019

jlewi commented Feb 14, 2019

k8s-ci-robot commented Feb 14, 2019

fixes 'add docker-for-desktop platform to kfctl (golang)' #2433

fixes 'add docker-for-desktop platform to kfctl (golang)' #2433

Conversation

kkasravi commented Feb 8, 2019 • edited by jlewi Loading

jlewi commented Feb 10, 2019

ashahba left a comment

Choose a reason for hiding this comment

ashahba Feb 10, 2019

Choose a reason for hiding this comment

ashahba Feb 10, 2019

Choose a reason for hiding this comment

ashahba Feb 10, 2019

Choose a reason for hiding this comment

ashahba Feb 10, 2019

Choose a reason for hiding this comment

ashahba Feb 10, 2019

Choose a reason for hiding this comment

kkasravi Feb 12, 2019

Choose a reason for hiding this comment

kkasravi left a comment

Choose a reason for hiding this comment

kkasravi commented Feb 12, 2019

kkasravi commented Feb 12, 2019

kkasravi left a comment

Choose a reason for hiding this comment

jlewi left a comment

Choose a reason for hiding this comment

jlewi commented Feb 14, 2019

kkasravi left a comment

Choose a reason for hiding this comment

kkasravi commented Feb 14, 2019

jlewi commented Feb 14, 2019

k8s-ci-robot commented Feb 14, 2019

kkasravi commented Feb 8, 2019 •

edited by jlewi

Loading