Skip to content
This repository has been archived by the owner on Feb 1, 2022. It is now read-only.

XGBoost Operator: Refactor manifests structure #114

Merged

Conversation

yanniszark
Copy link
Contributor

Umbrella-Issue: kubeflow/manifests#1769

XGBoost Operator

Current manifests structure

manifests
└── xgboost-operator
    ├── base
    └── overlays
        └── application

Explanation

Recommended end state

manifests
├── base
└── overlays
    └── kubeflow

In the future, we'd like base to import the kubebuilder-generated manifests.

@yanniszark
Copy link
Contributor Author

cc @kubeflow/wg-training-leads

README.md Outdated

```bash
kubectl kustomize base | kubectl apply -f -
kustomize build overlays/kubeflow | kubectl apply -f -
Copy link
Member

@terrytangyuan terrytangyuan Mar 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we stick with kubectl kustomize?

Copy link
Contributor Author

@yanniszark yanniszark Mar 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@terrytangyuan sure! I removed it because it uses a deprecated kustomize version.

Signed-off-by: Yannis Zarkadas <[email protected]>
@yanniszark yanniszark force-pushed the feature-consolidate-manifests branch from 746badd to 4fcaa37 Compare March 19, 2021 17:53
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan, yanniszark

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants