Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix registered issue for aws overlay of Jupyter-web-app #1330

Merged
merged 1 commit into from
Jun 29, 2020
Merged

Fix registered issue for aws overlay of Jupyter-web-app #1330

merged 1 commit into from
Jun 29, 2020

Conversation

PatrickXYS
Copy link
Member

Which issue is resolved by this Pull Request:
Resolves #1182

Description of your changes:
Use configmap with a different name rather than configmapGenerator, and patch jupyter-web-app deployment to render the configmap.

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate-changed-only
    3. make test

@kubeflow-bot
Copy link
Contributor

This change is Reviewable

@PatrickXYS
Copy link
Member Author

/assign @Jeffwan

@Jeffwan
Copy link
Member

Jeffwan commented Jun 26, 2020

/lgtm
/approve

@Jeffwan Jeffwan changed the title Fix Registered Issue for aws overlay of Jupyter-web-app Fix registered issue for aws overlay of Jupyter-web-app Jun 26, 2020
@PatrickXYS
Copy link
Member Author

/assign @kimwnasptd

@PatrickXYS
Copy link
Member Author

/assign @lluunn

@k8s-ci-robot
Copy link
Contributor

@PatrickXYS: GitHub didn't allow me to assign the following users: lluunn.

Note that only kubeflow members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @lluunn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@PatrickXYS
Copy link
Member Author

/cc @kimwnasptd Can you take a look? We want to cherry-pick along with 1.1.

@Jeffwan
Copy link
Member

Jeffwan commented Jun 29, 2020

/cc @terrytangyuan Yuan has permission to approve this change as well. This has been reviewed. Thanks!

terrytangyuan
terrytangyuan approved these changes Jun 29, 2020
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d51e314 into kubeflow:master Jun 29, 2020
Jeffwan added a commit to Jeffwan/manifests that referenced this pull request Jun 29, 2020
@Jeffwan
Fix Registered Issue for aws overlay of Jupyter-web-app (kubeflow#1330)
b5ee3a3
This was referenced Jun 29, 2020
Closed
Merged
k8s-ci-robot pushed a commit that referenced this pull request Jun 29, 2020
@Jeffwan
Cherry pick AWS changes #1299 #1312 #1326 #1327 #1328 #1330 to v1.1-b…
fb95d8c 
…ranch (#1334)

* Add Support For AWS Dex Basic-Authentication (#1299)

* Upgrade aws cognito manifest istio version to 1.3.1 (#1312)

* Update mxnet-operator manifest to v1 (#1326)

* Add mxnet-operator to aws kfdefs (#1327)

* Enable IRSA by default for AWS users (#1328)

* Fix Registered Issue for aws overlay of Jupyter-web-app (#1330)
@PatrickXYS PatrickXYS mentioned this pull request Jul 25, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeffwan Jeffwan Jeffwan approved these changes

@terrytangyuan terrytangyuan terrytangyuan approved these changes

@kimwnasptd kimwnasptd Awaiting requested review from kimwnasptd

@krishnadurai krishnadurai Awaiting requested review from krishnadurai

Assignees

@Jeffwan Jeffwan

@kimwnasptd kimwnasptd

Labels
approved cla: yes lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jupyter-web-app fails with kustomize build for aws overlay
7 participants
@PatrickXYS @kubeflow-bot @Jeffwan @k8s-ci-robot @terrytangyuan @googlebot @kimwnasptd