Add PatrickXYS into reviewer list #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
k8s-ci-robot
requested review from
Jeffwan,
kunmingg,
terrytangyuan and
yanniszark
| @@ -24,5 +24,6 @@ rules: | |||
| - "" | |||
| resources: | |||
| - secrets | |||
| - configmaps | |||
There was a problem hiding this comment.
This doesn't seem intended?
There was a problem hiding this comment.
Right, I did a search, should be this PR: #1394.
The PR's run test actually failed after merged. Developers may forget to re-generate tests before merge. Thus, it falls back to my side when I generate tests.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Hi all, I have continuously contributed to kubeflow/manifests repo and excited to continue working on it.
Thus, I want to add myself into reviewer list to help manifests grow fast.
The list of my PR on manifests:
#1410
#1330
#1155
#982
#953
#952
Checklist:
cd manifests/testsmake generate-changed-onlymake test